[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6047: WIP: Support XDG v6
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-27 8:16:30
Message-ID: 20170627081629.68597.9524754EC5D87AA8 () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D6047#119765, @graesslin wrote:
  
  > In https://phabricator.kde.org/D6047#119698, @mart wrote:
  >
  > > trying to implement the kwin part of ping btw, will do in a branch of the \
branch kwin/xdgv6  >
  >
  > no need to hurry with it. IMHO the way ping works is completely broken and won't \
work. At least Qt holds the connection in a thread, so it will react to the ping even \
if the application is frozen in the main gui thread.  
  
  any way to change this/make the gui thread actually answer?
  
  > Also please note that ping needs to be different in Wayland compared to X11. In \
X11 we only ping when trying to close the window. In Wayland we should ping whenever \
we interact with the window in some way. E.g. when we pass pointer focus, when we \
pass keyboard focus, maybe even when sending in input events.  
  if it's done in all input events, couldn't this affect performance?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D6047

To: davidedmundson, #plasma
Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6047" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6047#119765" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6047#119765</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6047#119698" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6047#119698</a>, <a \
href="https://phabricator.kde.org/p/mart/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@mart</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>trying to implement the kwin part of ping \
btw, will do in a branch of the branch kwin/xdgv6</p></div> </blockquote>

<p>no need to hurry with it. IMHO the way ping works is completely broken and \
won&#039;t work. At least Qt holds the connection in a thread, so it will react to \
the ping even if the application is frozen in the main gui thread.</p></div> \
</blockquote>

<p>any way to change this/make the gui thread actually answer?</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Also \
please note that ping needs to be different in Wayland compared to X11. In X11 we \
only ping when trying to close the window. In Wayland we should ping whenever we \
interact with the window in some way. E.g. when we pass pointer focus, when we pass \
keyboard focus, maybe even when sending in input events.</p></blockquote>

<p>if it&#039;s done in all input events, couldn&#039;t this affect \
performance?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R127 \
KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6047" \
rel="noreferrer">https://phabricator.kde.org/D6047</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, mart, plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]