[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-06-26 13:47:36
Message-ID: 20170626134736.34223.40F5FA9873FB2C9E () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> SizeHandle.qml:125
> +            if (wheel.delta > 0) {
> +                panel.thickness = Math.max(units.gridUnit, panel.thickness + 1);
> +            } else if (wheel.delta < 0) {

You need to make it by 2.

See desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml:50:

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

To: Zren, #plasma
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6392" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6392#inline-26343" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">SizeHandle.qml:125</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">            <span style="color: \
#aa4000">if</span> <span class="p">(</span><span style="color: \
#004012">wheel</span><span class="p">.</span><span style="color: \
#004012">delta</span> <span style="color: #aa2211">&gt;</span> <span style="color: \
#601200">0</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #004012">panel</span><span class="p">.</span><span style="color: \
#004012">thickness</span> <span style="color: #aa2211">=</span> <span style="color: \
#304a96">Math</span><span class="p">.</span><span style="color: \
#004012">max</span><span class="p">(</span><span style="color: \
#004012">units</span><span class="p">.</span><span style="color: \
#004012">gridUnit</span><span class="p">,</span> <span style="color: \
#004012">panel</span><span class="p">.</span><span style="color: \
#004012">thickness</span> <span style="color: #aa2211">+</span> <span style="color: \
#601200">1</span><span class="p">);</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #004012">wheel</span><span \
class="p">.</span><span style="color: #004012">delta</span> <span style="color: \
#aa2211">&lt;</span> <span style="color: #601200">0</span><span class="p">)</span> \
<span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
need to make it by 2.</p>

<p style="padding: 0; margin: 8px;">See \
desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml:50:</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6392" \
rel="noreferrer">https://phabricator.kde.org/D6392</a></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>davidedmundson, \
broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]