[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness
From:       Chris Holland <noreply () phabricator ! kde ! org>
Date:       2017-06-26 13:17:53
Message-ID: differential-rev-PHID-DREV-3f3uxvkx6ft2opmzfrny-req () phabricator ! kde ! org
[Download RAW message or body]

Zren created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The current thickness is also shown when dragging as well.
  Closing the ruler thing and reopening will recreate the component, so the \
Width/Height text will reset.  
  I could use `Qt.binding(funtion(){ return panel.thickness })` but I don't think the \
panel will procedurally change with the panel's config open.  
  Bug 372364: https://bugs.kde.org/show_bug.cgi?id=372364
  Reddit: https://www.reddit.com/r/kde/comments/65wdow/can_we_get_some_support_for_pixel_perfect_panel/
  
  Here's a demo: https://streamable.com/m2o7c
  
  Not intended:
  Moving the panel's screen edge triggered the `panel.onThicknessChanged`
  Demo: https://streamable.com/8jof7
  
  The best way to fix that is probably setting `button.text = panel.thickness` in the \
mousewheel event and in every case in the "drag" onPositionChanged event. Unless \
someone else can think of something better.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6392

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: Zren, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">Zren created this revision.<br />Restricted Application added \
a project: Plasma.<br />Restricted Application added a subscriber: plasma-devel. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6392" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The \
current thickness is also shown when dragging as well.<br /> Closing the ruler thing \
and reopening will recreate the component, so the Width/Height text will reset.</p>

<p>I could use <tt style="background: #ebebeb; font-size: \
13px;">Qt.binding(funtion(){ return panel.thickness })</tt> but I don&#039;t think \
the panel will procedurally change with the panel&#039;s config open.</p>

<p>Bug 372364: <a href="https://bugs.kde.org/show_bug.cgi?id=372364" \
class="remarkup-link" target="_blank" \
                rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=372364</a><br \
                />
Reddit: <a href="https://www.reddit.com/r/kde/comments/65wdow/can_we_get_some_support_for_pixel_perfect_panel/" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://www.reddit.com/r/kde/comments/65wdow/can_we_get_some_support_for_pixel_perfect_panel/</a></p>


<p>Here&#039;s a demo: <a href="https://streamable.com/m2o7c" class="remarkup-link" \
target="_blank" rel="noreferrer">https://streamable.com/m2o7c</a></p>

<p>Not intended:<br />
Moving the panel&#039;s screen edge triggered the <tt style="background: #ebebeb; \
                font-size: 13px;">panel.onThicknessChanged</tt><br />
Demo: <a href="https://streamable.com/8jof7" class="remarkup-link" target="_blank" \
rel="noreferrer">https://streamable.com/8jof7</a></p>

<p>The best way to fix that is probably setting <tt style="background: #ebebeb; \
font-size: 13px;">button.text = panel.thickness</tt> in the mousewheel event and in \
every case in the &quot;drag&quot; onPositionChanged event. Unless someone else can \
think of something better.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6392" \
rel="noreferrer">https://phabricator.kde.org/D6392</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml</div></div></div><br \
/><div><strong>To: </strong>Zren, Plasma<br /><strong>Cc: </strong>plasma-devel, \
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]