[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6313: WIP: Support device pixel ratio in icon loader and engine
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-26 8:58:58
Message-ID: 20170626085858.76358.C52009CF1AFCE7AB () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D6313#118285, @kvermette wrote:
  
  > Behaviorally speaking there's justification for ensuring SVGs are treated the \
same as PNGs in this case. Looking at the code we aren't shimming the SVGs \
specifically (unless I'm missing something), but I just wanted to chime in with this \
and nip special treatment for SVGs in the bud. In maintaining the Aether icon theme I \
would create links to the higher resolution icons, so you'd see something like a \
"16x16x2" folder point to my "32x32" 'native' folder, and a "16x16x3"->"48x48" \
folder, "32x32x2"->"64x64", etc. Just because we *can* scale SVG icons doesn't mean \
that behavior should be assumed, should the icon set have higher fidelity icons ready \
for HiDPI.  
  
  i think for svgs 16x16x2 should be preferred over scaling by 2 the 16x16 version, \
but still, scaling the 16x16 version should still be preferred over the 32x32 \
version, so this patch is on the right rirection

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: mart, kvermette, cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6313" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6313#118285" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6313#118285</a>, <a \
href="https://phabricator.kde.org/p/kvermette/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@kvermette</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Behaviorally speaking there&#039;s \
justification for ensuring SVGs are treated the same as PNGs in this case. Looking at \
the code we aren&#039;t shimming the SVGs specifically (unless I&#039;m missing \
something), but I just wanted to chime in with this and nip special treatment for \
SVGs in the bud. In maintaining the Aether icon theme I would create links to the \
higher resolution icons, so you&#039;d see something like a &quot;16x16x2&quot; \
folder point to my &quot;32x32&quot; &#039;native&#039; folder, and a \
&quot;16x16x3&quot;-&gt;&quot;48x48&quot; folder, \
&quot;32x32x2&quot;-&gt;&quot;64x64&quot;, etc. Just because we *can* scale SVG icons \
doesn&#039;t mean that behavior should be assumed, should the icon set have higher \
fidelity icons ready for HiDPI.</p></div> </blockquote>

<p>i think for svgs 16x16x2 should be preferred over scaling by 2 the 16x16 version, \
but still, scaling the 16x16 version should still be preferred over the 32x32 \
version, so this patch is on the right rirection</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R302 KIconThemes</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6313" \
rel="noreferrer">https://phabricator.kde.org/D6313</a></div></div><br \
/><div><strong>To: </strong>broulik, kde-frameworks-devel, Plasma, VDG<br \
/><strong>Cc: </strong>mart, kvermette, cfeck, davidedmundson, plasma-devel, \
Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]