[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6343: Add a check for whether the item isn't actually visible
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-06-22 14:21:10
Message-ID: differential-rev-PHID-DREV-pgv5exgpra4nrt7footd-req () phabricator ! kde ! org
[Download RAW message or body]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  if width or height is 0 we just get warnings such as:
  QImage::scaled: Image is a null image
  
  And in the end we're performing void operations that we could skip
  altohether.

TEST PLAN
  Now I can run KAlgebra without the warning

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6343

AFFECTED FILES
  src/desktopicon.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">apol created this revision.<br />Restricted Application added \
a project: Kirigami.<br />Restricted Application added a subscriber: plasma-devel. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6343" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>if width \
or height is 0 we just get warnings such as:<br /> QImage::scaled: Image is a null \
image</p>

<p>And in the end we&#039;re performing void operations that we could skip<br />
altohether.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Now I can run \
KAlgebra without the warning</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6343" \
rel="noreferrer">https://phabricator.kde.org/D6343</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/desktopicon.cpp</div></div></div><br /><div><strong>To: \
</strong>apol, Kirigami, mart<br /><strong>Cc: </strong>plasma-devel, apol, mart<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]