[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)
From:       Martin Koller <kollix () aon ! at>
Date:       2017-06-17 13:58:28
Message-ID: 20170617135828.7530.25724 () mimi ! kde ! org
[Download RAW message or body]

--===============2719923891757770508==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/
-----------------------------------------------------------

(Updated June 17, 2017, 1:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Kåre Särs.


Bugs: 373776
    http://bugs.kde.org/show_bug.cgi?id=373776


Repository: kdeplasma-addons


Description
-------

See bug #373776
The CPU bars do not show a value when using separate bars per CPU, and the tooltip \
never shows a value per CPU, since the data sources per CPU are not subscribed.

AFAICT this could never have worked.


Diffs
-----

  applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 

Diff: https://git.reviewboard.kde.org/r/129838/diff/


Testing
-------

yes


Thanks,

Martin Koller


--===============2719923891757770508==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129838/">https://git.reviewboard.kde.org/r/129838/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Kåre Särs.</div>
<div>By Martin Koller.</div>


<p style="color: grey;"><i>Updated June 17, 2017, 1:58 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=373776">373776</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See bug #373776 The CPU bars do not show a value when \
using separate bars per CPU, and the tooltip never shows a value per CPU, since the \
data sources per CPU are not subscribed.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">AFAICT this could never \
have worked.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">yes</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml <span \
style="color: grey">(32d98dd)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(5a0bc06)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129838/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2719923891757770508==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic