[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2017-06-12 5:37:48
Message-ID: 20170612053748.27103.6212 () mimi ! kde ! org
[Download RAW message or body]
--===============3897630826786402410==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 8, 2017, 3:47 p.m., Marco Martin wrote:
> > any update on this?
>
> Martin Koller wrote:
> Is there any reason this is held back ?
>
> Marco Martin wrote:
> No, could you push this?
Sorry! I have totally missed the updated comments :( Please commit.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102476
-----------------------------------------------------------
On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2017, 2:36 p.m.)
>
>
> Review request for Plasma and Kåre Särs.
>
>
> Bugs: 373776
> http://bugs.kde.org/show_bug.cgi?id=373776
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the tooltip \
> never shows a value per CPU, since the data sources per CPU are not subscribed.
>
> AFAICT this could never have worked.
>
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06
>
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Martin Koller
>
>
--===============3897630826786402410==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129838/">https://git.reviewboard.kde.org/r/129838/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 8th, 2017, 3:47 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">any update on this?</p></pre> </blockquote>
<p>On June 11th, 2017, 12:18 p.m. UTC, <b>Martin Koller</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is \
there any reason this is held back ?</p></pre> </blockquote>
<p>On June 11th, 2017, 6:37 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
could you push this?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry! I have totally \
missed the updated comments :( Please commit.</pre> <br />
<p>- Kåre</p>
<br />
<p>On January 15th, 2017, 2:36 p.m. UTC, Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Kåre Särs.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2017, 2:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=373776">373776</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See bug #373776 The CPU bars do not show a value when \
using separate bars per CPU, and the tooltip never shows a value per CPU, since the \
data sources per CPU are not subscribed.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">AFAICT this could never \
have worked.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">yes</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml <span \
style="color: grey">(32d98dd)</span></li>
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(5a0bc06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129838/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3897630826786402410==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic