[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6026: Add setScale option to kscreendoctor
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-05 12:10:59
Message-ID: 20170605121038.68206.82A0853F4845282A () phabricator ! kde ! org
[Download RAW message or body]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> doctor.cpp:227
> +                } else if (ops.count() == 4 && ops[2] == QStringLiteral("scale")) \
> { +                    int  scale = ops[3].toInt(&ok);
> +                    if (!ok) {

would make a sense to guard from here against values < 1 or very big?

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6026

To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart accepted this revision.<br />mart added inline \
comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6026" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D6026#inline-25048" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">doctor.cpp:227</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="bright">                \
</span><span class="p"><span class="bright">}</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">else</span></span><span \
class="bright"> </span><span style="color: #aa4000"><span \
class="bright">if</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">ops</span></span><span class="bright"></span><span class="p"><span \
class="bright">.</span></span><span class="bright"></span><span class="n"><span \
class="bright">count</span></span><span class="bright"></span><span class="p"><span \
class="bright">()</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">==</span></span><span class="bright"> </span><span \
style="color: #601200"><span class="bright">4</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span \
class="bright">&amp;&amp;</span></span><span class="bright"> </span><span \
class="n"><span class="bright">ops</span></span><span class="bright"></span><span \
class="p"><span class="bright">[</span></span><span class="bright"></span><span \
style="color: #601200"><span class="bright">2</span></span><span \
class="bright"></span><span class="p"><span class="bright">]</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright">==</span></span><span class="bright"> </span><span class="n"><span \
class="bright">QStringLiteral</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #766510"><span class="bright">&quot;scale&quot;</span></span><span \
class="bright"></span><span class="p"><span class="bright">))</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">                    <span style="color: #aa4000">int</span>  <span \
class="n">scale</span> <span style="color: #aa2211">=</span> <span \
class="n">ops</span><span class="p">[</span><span style="color: \
#601200">3</span><span class="p">].</span><span class="n">toInt</span><span \
class="p">(</span><span style="color: #aa2211">&amp;</span><span \
class="n">ok</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">ok</span><span class="p">)</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">would make a sense to guard from here against values &lt; 1 or very \
big?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R110 KScreen Library</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6026" \
rel="noreferrer">https://phabricator.kde.org/D6026</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, mart<br /><strong>Cc: \
</strong>mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]