[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-05-31 12:45:02
Message-ID: 20170531124457.105967.F8E29B0EFAE67C08 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  but as you say, we should never be in here, that's the entire sentiment of the \
comment above here.  
    // Since we haven't been able to figure out the reason why
    // this happens, we are adding this debug code to try to
    // figure out how this happened.
  
  As you can concretely reproduce it, can you look at fixing the actual issue?

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D6011

To: clutz
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6011" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>but as you say, we should never be in \
here, that&#039;s the entire sentiment of the comment above here.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">// Since we haven&#039;t been \
able to figure out the reason why // this happens, we are adding this debug code to \
try to // figure out how this happened.</pre></div>

<p>As you can concretely reproduce it, can you look at fixing the actual \
issue?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R110 KScreen \
Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6011" \
rel="noreferrer">https://phabricator.kde.org/D6011</a></div></div><br \
/><div><strong>To: </strong>clutz<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]