[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6017: Don't leak MimeData object
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-05-31 9:05:41
Message-ID: 20170531090540.6240.C3EC290CF6530228 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > So you're cleaning up the leak the next time the getter is accessed?
  
  No? If it's accessed again m_data is not null so we don't get in that branch
  
  The main cleanup is implicitly in the DeclarativeDropEvent destructor

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6017

To: davidedmundson, #plasma, mart
Cc: hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6017" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>So you&#039;re cleaning up the leak the next time the \
getter is accessed?</p></blockquote>

<p>No? If it&#039;s accessed again m_data is not null so we don&#039;t get in that \
branch</p>

<p>The main cleanup is implicitly in the DeclarativeDropEvent \
destructor</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 \
KDeclarative</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6017" \
rel="noreferrer">https://phabricator.kde.org/D6017</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, mart<br /><strong>Cc: \
</strong>hein, plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]