[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6027: Use existing parseInt function
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-05-30 14:26:01
Message-ID: differential-rev-PHID-DREV-okmdaqsgvrvrn6specqj-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There's already a QString::toInt() that validates input. We don't need
  to make our own.
  
  Also there was a bug in the current point parsing code if the first was
  invalid but the second valid. Both need to be checked.

TEST PLAN
  Compiles

REPOSITORY
  R110 KScreen Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6027

AFFECTED FILES
  src/doctor/doctor.cpp
  src/doctor/doctor.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6027" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>There&#039;s already a QString::toInt() that validates input. \
We don&#039;t need<br /> to make our own.</p>

<p>Also there was a bug in the current point parsing code if the first was<br />
invalid but the second valid. Both need to be checked.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Compiles</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R110 KScreen Library</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6027" \
rel="noreferrer">https://phabricator.kde.org/D6027</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/doctor/doctor.cpp<br /> \
src/doctor/doctor.h</div></div></div><br /><div><strong>To: </strong>davidedmundson, \
Plasma<br /><strong>Cc: </strong>plasma-devel, ZrenBot, spstarr, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]