[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D3650: lower mouse acceleration limit to 0.0
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-05-30 13:18:55
Message-ID: 20170530131818.42261.50682DB062C5E483 () phabricator ! kde ! org
[Download RAW message or body]

apol added a comment.


  In https://phabricator.kde.org/D3650#80584, @graesslin wrote:
  
  > According to my comments in the Wayland port: the value 1.0 means no \
acceleration. Values below 1.0 mean a de-acceleration or a slow down. But \
it's still a factor. I'm also afraid that putting a 0.0 there could result \
in a devision by 0 value.  >
  > So in any case your commit message does not match the actual reality. \
And given that I think you are trying to fix the wrong problem. Might it be \
that you use the libinput xorg driver? If yes, that's not yet supported and \
needs porting. But this change has potential of breaking the non-libinput \
xorg driver then.  >
  > From my side something between -1 and -2 for this change.
  
  
  Does this mean that 0.0 means not moving at all? That doesn't sound \
right.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3650

To: sitter, plasma-devel
Cc: apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, progwolff, \
lesliezhai, ali-mohamed, abetts, sebas, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3650" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote \
style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D3650#80584" style="background-color: \
#e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" \
rel="noreferrer">D3650#80584</a>, <a \
href="https://phabricator.kde.org/p/graesslin/" style="  border-color: \
#f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> \
wrote:</div> <div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>According to my comments in the \
Wayland port: the value 1.0 means no acceleration. Values below 1.0 mean a \
de-acceleration or a slow down. But it&#039;s still a factor. I&#039;m also \
afraid that putting a 0.0 there could result in a devision by 0 value.</p>

<p>So in any case your commit message does not match the actual reality. \
And given that I think you are trying to fix the wrong problem. Might it be \
that you use the libinput xorg driver? If yes, that&#039;s not yet \
supported and needs porting. But this change has potential of breaking the \
non-libinput xorg driver then.</p>

<p>From my side something between -1 and -2 for this change.</p></div>
</blockquote>

<p>Does this mean that 0.0 means not moving at all? That doesn&#039;t sound \
right.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 \
Plasma Desktop</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D3650" \
rel="noreferrer">https://phabricator.kde.org/D3650</a></div></div><br \
/><div><strong>To: </strong>sitter, plasma-devel<br /><strong>Cc: \
</strong>apol, graesslin, broulik, jensreuterberg, ZrenBot, spstarr, \
progwolff, lesliezhai, ali-mohamed, abetts, sebas, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]