[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D1230: GBM remote access support for KWin
From:       Oleg Chernovskiy <noreply () phabricator ! kde ! org>
Date:       2017-05-30 9:30:21
Message-ID: 20170530093020.84211.F95E7989BD57235B () phabricator ! kde ! org
[Download RAW message or body]

Kanedias added inline comments.

INLINE COMMENTS

> davidedmundson wrote in drm_buffer.cpp:131
> If it's deferred it means someone else is doing the gbm_surface_release.
> 
> But we still need to set m_bo to nullptr. Otherwise it's potentially left dangling \
> here after the RemoteAccessManager has deleted it. 
> (Alternately: if we changed DrmObjectPlane to store the buffers as QSharedPointers \
> we could just keep a reference to the DrmBuffer in the RemoteAccessManager, which \
> would be IMHO cleaner than doing low level GBM stuff there and having the data \
> released in one of two places. I'll look into that)

I rewrote this part since this change and it doesn't touch buffers now, if you want \
to take a look at it prior to my resubmission, it's there:

https://gitlab.com/Kanedias/kwin/commit/9535f36bd09f8834be3773f25bf2075a720ba1c4

> davidedmundson wrote in remoteaccess_manager.h:49-50
> what's this signal for?

Forgot to get rid of it, thanks

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">Kanedias added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1230" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1230#inline-24724" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">drm_buffer.cpp:131</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">If it&#039;s deferred it means \
someone else is doing the gbm_surface_release.</p>

<p style="padding: 0; margin: 8px;">But we still need to set m_bo to nullptr. \
Otherwise it&#039;s potentially left dangling here after the RemoteAccessManager has \
deleted it.</p>

<p style="padding: 0; margin: 8px;">(Alternately: if we changed DrmObjectPlane to \
store the buffers as QSharedPointers we could just keep a reference to the DrmBuffer \
in the RemoteAccessManager, which would be IMHO cleaner than doing low level GBM \
stuff there and having the data released in one of two places. I&#039;ll look into \
that)</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">I rewrote this part since this change and it doesn&#039;t touch \
buffers now, if you want to take a look at it prior to my resubmission, it&#039;s \
there:</p>

<p style="padding: 0; margin: 8px;"><a \
href="https://gitlab.com/Kanedias/kwin/commit/9535f36bd09f8834be3773f25bf2075a720ba1c4" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://gitlab.com/Kanedias/kwin/commit/9535f36bd09f8834be3773f25bf2075a720ba1c4</a></p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1230#inline-24723" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">davidedmundson</span> \
wrote in <span style="color: #4b4d51; font-weight: \
bold;">remoteaccess_manager.h:49-50</span></div> <div style="margin: 8px 0; padding: \
0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">what&#039;s this signal \
for?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">Forgot to get rid of it, thanks</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1230" \
rel="noreferrer">https://phabricator.kde.org/D1230</a></div></div><br \
/><div><strong>To: </strong>Kanedias, graesslin, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]