[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6017: Don't leak MimeData object
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-05-29 21:34:58
Message-ID: differential-rev-PHID-DREV-67i3ujfqd7uucheepuc3-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  A DeclarativeDropArea creates a new DeclarativeDragDropEvent on every
  enter/move/leave event.
  
  The getter method for the mimeData property creates a new MimeData
  QObject wrapper, which then leaks.
  
  Use of the mimeData object outside of the event shouldn't be expected to
  work, and a quick grep couldn't find any usage.
  
  BUG: 380270

TEST PLAN
  Dragged some things

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6017

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp
  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added projects: Plasma, Frameworks.<br />Restricted Application added \
subscribers: Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6017" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>A \
DeclarativeDropArea creates a new DeclarativeDragDropEvent on every<br /> \
enter/move/leave event.</p>

<p>The getter method for the mimeData property creates a new MimeData<br />
QObject wrapper, which then leaks.</p>

<p>Use of the mimeData object outside of the event shouldn&#039;t be expected to<br \
/> work, and a quick grep couldn&#039;t find any usage.</p>

<p>BUG: 380270</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Dragged \
some things</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R296 \
KDeclarative</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6017" \
rel="noreferrer">https://phabricator.kde.org/D6017</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp<br \
/> src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]