[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5976: Remove code to poll the udev events for brightness
From:       Bhushan Shah <noreply () phabricator ! kde ! org>
Date:       2017-05-26 15:53:09
Message-ID: differential-rev-PHID-DREV-noh2mq7u2fhwb7jpgidw-req () phabricator ! kde ! org
[Download RAW message or body]

bshah created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This code watches the device in the sysfs for changes, if device is
  changed it reads the brightness again and updates it.
  
  However that is,
  
  a) Redundant: as if we update the brightness we already know what
  brightness we set it to
  
  b) Covers corner case: If something other then powerdevil updates the
  brightness, this will update the internal brightness code accordingly
  
  So, lets remove this extra overhead of going through udev/uevent and
  make things bit more simpler

TEST PLAN
  tested brightness control using keyboard, battery monitor

REPOSITORY
  R122 Powerdevil

BRANCH
  remove-udevqt

REVISION DETAIL
  https://phabricator.kde.org/D5976

AFFECTED FILES
  CMakeLists.txt
  cmake/FindUDev.cmake
  daemon/CMakeLists.txt
  daemon/backends/CMakeLists.txt
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/powerdevilupowerbackend.h
  daemon/backends/upower/udevqt.h
  daemon/backends/upower/udevqt_p.h
  daemon/backends/upower/udevqtclient.cpp
  daemon/backends/upower/udevqtclient.h
  daemon/backends/upower/udevqtdevice.cpp
  daemon/backends/upower/udevqtdevice.h

To: bshah, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">bshah created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5976" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
code watches the device in the sysfs for changes, if device is<br /> changed it reads \
the brightness again and updates it.</p>

<p>However that is,</p>

<p>a) Redundant: as if we update the brightness we already know what<br />
brightness we set it to</p>

<p>b) Covers corner case: If something other then powerdevil updates the<br />
brightness, this will update the internal brightness code accordingly</p>

<p>So, lets remove this extra overhead of going through udev/uevent and<br />
make things bit more simpler</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>tested brightness control using keyboard, battery \
monitor</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 \
Powerdevil</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>remove-udevqt</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5976" \
rel="noreferrer">https://phabricator.kde.org/D5976</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br /> \
cmake/FindUDev.cmake<br /> daemon/CMakeLists.txt<br />
daemon/backends/CMakeLists.txt<br />
daemon/backends/upower/powerdevilupowerbackend.cpp<br />
daemon/backends/upower/powerdevilupowerbackend.h<br />
daemon/backends/upower/udevqt.h<br />
daemon/backends/upower/udevqt_p.h<br />
daemon/backends/upower/udevqtclient.cpp<br />
daemon/backends/upower/udevqtclient.h<br />
daemon/backends/upower/udevqtdevice.cpp<br />
daemon/backends/upower/udevqtdevice.h</div></div></div><br /><div><strong>To: \
</strong>bshah, Plasma, broulik<br /><strong>Cc: </strong>plasma-devel, ZrenBot, \
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, \
mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]