[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve 
From:       Elvis Angelaccio <noreply () phabricator ! kde ! org>
Date:       2017-05-16 11:29:20
Message-ID: differential-rev-PHID-DREV-7xoyizk4npdyo2xd3vnv-req () phabricator ! kde ! org
[Download RAW message or body]

elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: Dolphin, Konqueror, plasma-devel.

REVISION SUMMARY
  This reverts commit \
https://phabricator.kde.org/R318:58c5eae1953bbdcf6d4150b21cb7ffdad07a5257.  
  Reasons against this change:
  
  1. Scroll is now too fast with devices such as touchpads or trackpoints.
  2. Scroll behavior is now inconsistent between Dolphin and other applications (e.g. \
the Plasma file dialog). Breeze's default animation duration is 100 ms.  3. Many \
people complained and this feature is currently not configurable. We should introduce \
a QStyle::SH_Widget_Animation_Duration hint that would allow us to not hardcode \
durations in Dolphin (i.e. respect whatever duration the users set in their QStyle).

REPOSITORY
  R318 Dolphin

BRANCH
  Applications/17.04

REVISION DETAIL
  https://phabricator.kde.org/D5883

AFFECTED FILES
  src/kitemviews/private/kitemlistsmoothscroller.cpp

To: elvisangelaccio, #vdg, #plasma, emmanuelp
Cc: plasma-devel, #konqueror, #dolphin, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (text/html)]

<table><tr><td style="">elvisangelaccio created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added subscribers: \
Dolphin, Konqueror, plasma-devel. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5883" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
reverts commit <a href="https://phabricator.kde.org/R318:58c5eae1953bbdcf6d4150b21cb7ffdad07a5257" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" \
rel="noreferrer">58c5eae1953bbdcf6d4150b21cb7ffdad07a5257</a>.</p>

<p>Reasons against this change:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Scroll is now too fast with devices such as touchpads \
or trackpoints.</li> <li class="remarkup-list-item">Scroll behavior is now \
inconsistent between Dolphin and other applications (e.g. the Plasma file dialog). \
Breeze&#039;s default animation duration is 100 ms.</li> <li \
class="remarkup-list-item">Many people complained and this feature is currently not \
configurable. We should introduce a QStyle::SH_Widget_Animation_Duration hint that \
would allow us to not hardcode durations in Dolphin (i.e. respect whatever duration \
the users set in their QStyle).</li> </ol></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R318 Dolphin</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Applications/17.04</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5883" \
rel="noreferrer">https://phabricator.kde.org/D5883</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/kitemviews/private/kitemlistsmoothscroller.cpp</div></div></div><br \
/><div><strong>To: </strong>elvisangelaccio, VDG, Plasma, emmanuelp<br /><strong>Cc: \
</strong>plasma-devel, Konqueror, Dolphin, ZrenBot, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]