[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5670: Avoid deep copy of image data when getting pixmaps in SNIs
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-04-30 22:16:20
Message-ID: differential-rev-PHID-DREV-bqxmv723xcn5rsvkq7wj-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We get the data as a QByteArray we can just ref the original data,
  rather than doing a deep copy of the data.
  
  Might save a few cycles when we have an SNI animating.

TEST PLAN
  Ran an app that I know uses xembedsniproxy which always sends data as an image
  Still had an icon in the system tray as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5670

AFFECTED FILES
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5670" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We get \
the data as a QByteArray we can just ref the original data,<br /> rather than doing a \
deep copy of the data.</p>

<p>Might save a few cycles when we have an SNI animating.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Ran an app that I know uses xembedsniproxy \
which always sends data as an image<br /> Still had an icon in the system tray as \
before</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5670" \
rel="noreferrer">https://phabricator.kde.org/D5670</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>dataengines/statusnotifieritem/statusnotifieritemsource.cpp</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]