[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5568: SFTP ioslave: Port away from KDELibs4Support
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2017-04-30 14:46:39
Message-ID: 20170430144638.126100.34948.B69C9982 () phabricator ! kde ! org
[Download RAW message or body]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:836
> // Handle user canceled or dialog failed to open...
> -        if (!openPasswordDialog(info, errMsg)) {
> +        if (openPasswordDialogV2(info, errMsg) != 0) {
> qCDebug(KIO_SFTP_LOG) << "User canceled password/retry dialog";

This should store the return value from openPasswordDialogV2 and use it in the error \
call 3 lines below, that's the whole point of the port to V2.

Same for the calls above, if possible (the patch doesn't show what the error handling \
is).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5568

To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas


[Attachment #3 (text/html)]

<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5568" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5568#inline-23129" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kio_sftp.cpp:836</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #74777d">// Handle user canceled or dialog failed to \
open...</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, \
175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">!</span></span><span \
class="n">openPasswordDialog</span><span class="p">(</span><span \
class="n">info</span><span class="p">,</span> <span class="n">errMsg</span><span \
class="p">))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">openPasswordDialog<span \
class="bright">V2</span></span><span class="p">(</span><span \
class="n">info</span><span class="p">,</span> <span class="n">errMsg</span><span \
class="p">)<span class="bright"></span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> \
</span><span style="color: #601200"><span class="bright">0</span></span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 8px; margin: \
0 4px; ">          <span class="n">qCDebug</span><span class="p">(</span><span \
class="n">KIO_SFTP_LOG</span><span class="p">)</span> <span style="color: \
#aa2211">&lt;&lt;</span> <span style="color: #766510">&quot;User canceled \
password/retry dialog&quot;</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
should store the return value from openPasswordDialogV2 and use it in the error call \
3 lines below, that&#039;s the whole point of the port to V2.</p>

<p style="padding: 0; margin: 8px;">Same for the calls above, if possible (the patch \
doesn&#039;t show what the error handling is).</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R320 KIO Extras</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5568" \
rel="noreferrer">https://phabricator.kde.org/D5568</a></div></div><br \
/><div><strong>To: </strong>marten, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]