[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5636: Fix KScreen KCM screen placement with scaled outputs
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-04-28 12:41:39
Message-ID: differential-rev-PHID-DREV-xqev2mwob3q6zz7l7vv2-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The QML part of the KCM gets the output size manually as it wants to do
  all translations itself.
  
  We need to divide the mode by the scale as wayland wants everything in
  normalised global co-ordinates.
  
  i.e a screen to the right of a 2x output with a mode of 2000 pixels,
  will have an X of 1000.

TEST PLAN
  Had a scaled output (set using kwin config)
  Moved some about. 
  They appeared exactly where it should have done.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5636

AFFECTED FILES
  kcm/src/declarative/qmloutput.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5636" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The QML \
part of the KCM gets the output size manually as it wants to do<br /> all \
translations itself.</p>

<p>We need to divide the mode by the scale as wayland wants everything in<br />
normalised global co-ordinates.</p>

<p>i.e a screen to the right of a 2x output with a mode of 2000 pixels,<br />
will have an X of 1000.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Had a scaled output (set using kwin config)<br /> Moved some \
about. <br /> They appeared exactly where it should have done.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5636" \
rel="noreferrer">https://phabricator.kde.org/D5636</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kcm/src/declarative/qmloutput.cpp</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]