[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5605: Allow multiple categories with the same name
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-04-27 15:15:47
Message-ID: 20170427151535.57455.25825.82316E40 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> atticaprovider.cpp:129
> qCDebug(KNEWSTUFFCORE) << "Adding category: " << category.name() << \
>                 category.displayName();
> -            mCategoryMap[category.name()] = category;
> +            mCategoryMap.insertMulti(category.name(), category);
> 

mCategoryMap is pre-populated with null categories in the constructor.

This looks like this now won't ever update them.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D5605

To: mart, #plasma, leinir, whiting
Cc: davidedmundson, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5605" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D5605#inline-22932" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">atticaprovider.cpp:129</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">            <span class="n">qCDebug</span><span \
class="p">(</span><span class="n">KNEWSTUFFCORE</span><span class="p">)</span> <span \
style="color: #aa2211">&lt;&lt;</span> <span style="color: #766510">&quot;Adding \
category: &quot;</span> <span style="color: #aa2211">&lt;&lt;</span> <span \
class="n">category</span><span class="p">.</span><span class="n">name</span><span \
class="p">()</span> <span style="color: #aa2211">&lt;&lt;</span> <span \
class="n">category</span><span class="p">.</span><span \
class="n">displayName</span><span class="p">();</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span \
class="n">mCategoryMap<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">[</span></span><span \
class="n">category</span><span class="p">.</span><span class="n">name</span><span \
class="p">()<span class="bright">]</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span> <span \
class="n">category</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span \
class="n">mCategoryMap<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span \
class="bright">insertMulti</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="n">category</span><span \
class="p">.</span><span class="n">name</span><span class="p">()<span \
class="bright">,</span></span> <span class="n">category<span \
class="bright"></span></span><span class="bright"></span><span class="p"><span \
class="bright">)</span>;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">mCategoryMap is pre-populated with null categories in the constructor.</p>

<p style="padding: 0; margin: 8px;">This looks like this now won&#039;t ever update \
them.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5605" \
rel="noreferrer">https://phabricator.kde.org/D5605</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, leinir, whiting<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, Frameworks, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]