[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5490: Only follow mouse when moved (Fixes Bug #372635)
From:       Leszek Lesner <noreply () phabricator ! kde ! org>
Date:       2017-04-20 14:29:28
Message-ID: 20170420142927.38883.6439.B0F21B94 () phabricator ! kde ! org
[Download RAW message or body]

leszeklesner added a comment.


  In https://phabricator.kde.org/D5490#103642, @davidedmundson wrote:
  
  > If I have the mouse outside the window, and then deliberately move the mouse in \
to select something, by design, this won't update the index the first time.  >
  > It'll fix your bug, sure - but we're knowingly introducing a different bug.
  >
  > What we need to do to fix the bug without regressions is separate the two events:
  >
  >   - the window expanding and us now containing the mouse
  > - the user actively moving the mouse into view.
  
  
  There is no way to distinguish between the two with the normal Qt offerings of \
containsMouse or Entered signals as both are recognized as mouse moving into the \
view.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D5490

To: leszeklesner, broulik
Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, \
spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">leszeklesner added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5490" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5490#103642" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D5490#103642</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>If I have the mouse outside the window, and \
then deliberately move the mouse in to select something, by design, this won&#039;t \
update the index the first time.</p>

<p>It&#039;ll fix your bug, sure - but we&#039;re knowingly introducing a different \
bug.</p>

<p>What we need to do to fix the bug without regressions is separate the two \
events:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item phantom-item"><ul class="remarkup-list">
<li class="remarkup-list-item">the window expanding and us now containing the \
mouse</li> </ul></li>
<li class="remarkup-list-item">the user actively moving the mouse into view.</li>
</ul></div>
</blockquote>

<p>There is no way to distinguish between the two with the normal Qt offerings of \
containsMouse or Entered signals as both are recognized as mouse moving into the \
view.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 \
Milou</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5490" \
rel="noreferrer">https://phabricator.kde.org/D5490</a></div></div><br \
/><div><strong>To: </strong>leszeklesner, broulik<br /><strong>Cc: </strong>ltoscano, \
qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]