[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5490: Only follow mouse when moved (Fixes Bug #372635)
From:       Leszek Lesner <noreply () phabricator ! kde ! org>
Date:       2017-04-18 13:43:37
Message-ID: 20170418134330.22997.28641.898B7F98 () phabricator ! kde ! org
[Download RAW message or body]

leszeklesner added a comment.


  In https://phabricator.kde.org/D5490#103059, @lfurmetz wrote:
  
  > In https://phabricator.kde.org/D5490#103053, @anthonyfieroni wrote:
  >
  > > You can do this:
  > >
  > >   property bool moved: false
  > >   onMovedChanged: if (moved) {
  > >       listView.currentIndex = index
  > >   }
  > >   onPositionChanged: {
  > >   ...
  > >   moved = true;
  > >   }
  > >
  >
  >
  > I tried this, but onPositionChanged doesn't fire for me at all in qt 4.8.0.. Is \
this a bug?  >
  > Is it possible to attach the property __moved to the parent ListView dynamically, \
so it can be checked by all delegates?  
  
  See my updated patch. It moves the moved property to listView and works much better \
than the previous patch.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D5490

To: leszeklesner, broulik
Cc: lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">leszeklesner added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5490" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5490#103059" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D5490#103059</a>, <a \
href="https://phabricator.kde.org/p/lfurmetz/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@lfurmetz</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5490#103053" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D5490#103053</a>, <a \
href="https://phabricator.kde.org/p/anthonyfieroni/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@anthonyfieroni</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>You can do this:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
                12px; margin: 0; background: rgba(71, 87, 120, 0.08);">property bool \
                moved: false
onMovedChanged: if (moved) {
    listView.currentIndex = index
}
onPositionChanged: {
...
moved = true;
}</pre></div></div>
</blockquote>

<p>I tried this, but onPositionChanged doesn&#039;t fire for me at all in qt 4.8.0.. \
Is this a bug?</p>

<p>Is it possible to attach the property __moved to the parent ListView dynamically, \
so it can be checked by all delegates?</p></div> </blockquote>

<p>See my updated patch. It moves the moved property to listView and works much \
better than the previous patch.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R112 Milou</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5490" \
rel="noreferrer">https://phabricator.kde.org/D5490</a></div></div><br \
/><div><strong>To: </strong>leszeklesner, broulik<br /><strong>Cc: </strong>lfurmetz, \
anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]