[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5490: Only follow mouse when moved (Fixes Bug #372635)
From:       Leszek Lesner <noreply () phabricator ! kde ! org>
Date:       2017-04-18 10:43:57
Message-ID: differential-rev-PHID-DREV-vtizgop26oymk5royu35-req () phabricator ! kde ! org
[Download RAW message or body]

leszeklesner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use a new variable __moved to detect if mouse moved and only change index if the \
mouse moved. This helps preventing index changes when only using keyboard to search \
something in milou and to not accidently start/open something you did not want (see \
bug report https://bugs.kde.org/show_bug.cgi?id=372635 )  
  In general the onEntered signal seems to be broken in Qt somehow as I could not \
make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the code using \
onEntered failed to work with onPositionChanged (I guess this also does not always \
set it to true).  Hence I tried containsMouse which seems to work reliably at least \
on Qt 5.7.1.   Tests are appreciated especially on other Qt versions.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D5490

AFFECTED FILES
  lib/qml/ResultDelegate.qml

To: leszeklesner, broulik
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">leszeklesner created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5490" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Use a \
new variable __moved to detect if mouse moved and only change index if the mouse \
moved. This helps preventing index changes when only using keyboard to search \
something in milou and to not accidently start/open something you did not want (see \
bug report <a href="https://bugs.kde.org/show_bug.cgi?id=372635" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=372635</a> )</p>

<p>In general the onEntered signal seems to be broken in Qt somehow as I could not \
make it work reliably with Qt 5.7.1. Sometimes it worked but mostly the code using \
onEntered failed to work with onPositionChanged (I guess this also does not always \
set it to true).<br /> Hence I tried containsMouse which seems to work reliably at \
least on Qt 5.7.1. <br /> Tests are appreciated especially on other Qt \
versions.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 \
Milou</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5490" \
rel="noreferrer">https://phabricator.kde.org/D5490</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>lib/qml/ResultDelegate.qml</div></div></div><br \
/><div><strong>To: </strong>leszeklesner, broulik<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]