[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5446: Implement support for selected mime type filters
From:       Elvis Angelaccio <noreply () phabricator ! kde ! org>
Date:       2017-04-15 9:05:45
Message-ID: 20170415090544.38417.80562.4BFEFE4D () phabricator ! kde ! org
[Download RAW message or body]

elvisangelaccio added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in qfiledialogtest.cpp:116
> ...or maybe we can turn the assert in a qWarning()? Otherwise if isMimeFilter() is \
> false we get a name filter instead of a mimetype, a bit misleading?

The problem is that if `isMimeFilter()` is false we get a name filter instead of a \
mimetype, which is not expected. This could be fixed by something like:

  if (m_fileWidget->filterWidget()->isMimeFilter()) {
      return m_fileWidget->filterWidget()->currentFilter();
  } else {
      // detect mimetype of selectedFiles() using QMimeDatabase
      ...
  }

Does it make sense?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D5446

To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">elvisangelaccio added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5446" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D5446#inline-22350" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">elvisangelaccio</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">qfiledialogtest.cpp:116</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">...or maybe we can turn \
the assert in a qWarning()? Otherwise if isMimeFilter() is false we get a name filter \
instead of a mimetype, a bit misleading?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">The problem is that if <tt \
style="background: #ebebeb; font-size: 13px;">isMimeFilter()</tt> is false we get a \
name filter instead of a mimetype, which is not expected.<br /> This could be fixed \
by something like:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if \
(m_fileWidget-&gt;filterWidget()-&gt;isMimeFilter()) {  return \
m_fileWidget-&gt;filterWidget()-&gt;currentFilter(); } else {
    // detect mimetype of selectedFiles() using QMimeDatabase
    ...
}</pre></div>

<p style="padding: 0; margin: 8px;">Does it make \
sense?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5446" \
rel="noreferrer">https://phabricator.kde.org/D5446</a></div></div><br \
/><div><strong>To: </strong>elvisangelaccio, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]