[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D5446: Implement support for selected mime type filters
From: David Faure <noreply () phabricator ! kde ! org>
Date: 2017-04-15 8:02:01
Message-ID: 20170415080054.38620.61982.1BC6D378 () phabricator ! kde ! org
[Download RAW message or body]
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfiledialog_unittest.cpp:84
> +
> + QMimeType headerMime = QMimeDatabase().mimeTypeForName(QStringLiteral("text/x-chdr"));
> + QMimeType jsonMime = QMimeDatabase().mimeTypeForName(QStringLiteral("application/json"));
Why use QMimeDatabase, just to then use name()? You could just put "text/x-chdr" in the data row, no?
> kfiledialog_unittest.cpp:116
> + QEXPECT_FAIL("", "QFileDialog in Qt < 5.9 does not report the selected mime type.", Continue);
> + QCOMPARE(QString(), targetMimeTypeFilter);
> +#endif
Surely you mean QCOMPARE(dialog.selectedMimeTypeFilter(), QString())
> kdeplatformfiledialoghelper.cpp:181
> +{
> + Q_ASSERT(m_fileWidget->filterWidget()->isMimeFilter());
> + return m_fileWidget->filterWidget()->currentFilter();
Are you sure this ASSERT is wanted? See next comment.
> qfiledialogtest.cpp:116
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)
> + qDebug() << "selected mime type filter" << dialog.selectedMimeTypeFilter();
> +#endif
this code looks ok to me, but it will hit the above assert when the -mimeTypeFilter option is absent, no?
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D5446
To: elvisangelaccio, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5446" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5446#inline-22338" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kfiledialog_unittest.cpp:84</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QMimeType</span> <span class="n">headerMime</span> <span style="color: \
#aa2211">=</span> <span class="n">QMimeDatabase</span><span class="p">().</span><span \
class="n">mimeTypeForName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"text/x-chdr"</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="n">QMimeType</span> <span class="n">jsonMime</span> <span style="color: \
#aa2211">=</span> <span class="n">QMimeDatabase</span><span class="p">().</span><span \
class="n">mimeTypeForName</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"application/json"</span><span class="p">));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Why use QMimeDatabase, just to then use name()? You could just put \
"text/x-chdr" in the data row, no?</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5446#inline-22339" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kfiledialog_unittest.cpp:116</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">QEXPECT_FAIL</span><span class="p">(</span><span style="color: \
#766510">""</span><span class="p">,</span> <span style="color: \
#766510">"QFileDialog in Qt < 5.9 does not report the selected mime \
type."</span><span class="p">,</span> <span class="n">Continue</span><span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span \
class="p">(</span><span class="n">QString</span><span class="p">(),</span> <span \
class="n">targetMimeTypeFilter</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#endif</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Surely you mean QCOMPARE(dialog.selectedMimeTypeFilter(), \
QString())</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D5446#inline-22341" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kdeplatformfiledialoghelper.cpp:181</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">Q_ASSERT</span><span class="p">(</span><span \
class="n">m_fileWidget</span><span style="color: #aa2211">-></span><span \
class="n">filterWidget</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">isMimeFilter</span><span class="p">());</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">return</span> <span \
class="n">m_fileWidget</span><span style="color: #aa2211">-></span><span \
class="n">filterWidget</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">currentFilter</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Are you sure this ASSERT is wanted? See next \
comment.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D5446#inline-22340" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">qfiledialogtest.cpp:116</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> \
</span><span class="n"><span class="bright">qDebug</span></span><span \
class="bright"></span><span class="p"><span class="bright">()</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright"><<</span></span><span class="bright"> </span><span style="color: \
#766510"><span class="bright">"selected name nameFilter"</span></span><span \
class="bright"> </span><span style="color: #aa2211"><span \
class="bright"><<</span></span><span class="bright"> </span><span \
class="n"><span class="bright">dialog</span></span><span class="bright"></span><span \
class="p"><span class="bright">.</span></span><span class="bright"></span><span \
class="n"><span class="bright">selectedNameFilter</span></span><span \
class="bright"></span><span class="p"><span class="bright">();</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="bright"></span><span style="color: #304a96"><span \
class="bright">#if QT_VERSION >= QT_VERSION_CHECK(5, 9, 0)</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span class="n">qDebug</span><span class="p">()</span> <span \
style="color: #aa2211"><<</span> <span style="color: #766510">"selected \
mime type filter"</span> <span style="color: #aa2211"><<</span> <span \
class="n">dialog</span><span class="p">.</span><span \
class="n">selectedMimeTypeFilter</span><span class="p">();</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#endif</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this \
code looks ok to me, but it will hit the above assert when the -mimeTypeFilter option \
is absent, no?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5446" \
rel="noreferrer">https://phabricator.kde.org/D5446</a></div></div><br \
/><div><strong>To: </strong>elvisangelaccio, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic