[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files
From:       Anthony Fieroni <noreply () phabricator ! kde ! org>
Date:       2017-04-13 14:11:02
Message-ID: 20170413141053.23558.39630.7ABE16EC () phabricator ! kde ! org
[Download RAW message or body]

anthonyfieroni added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370
> Sorry but I didn't think about Qt 5.10.x which would break this check. So please \
> ignore my suggestion here.

http://doc.qt.io/qt-5/qversionnumber.html

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D4193

To: arichardson, #plasma
Cc: anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4193" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4193#inline-22207" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">elvisangelaccio</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">kdeplatformfiledialoghelper.cpp:365-370</span></div> <div style="margin: 8px \
0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Sorry but I \
didn&#039;t think about Qt 5.10.x which would break this check. So please ignore my \
suggestion here.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;"><a href="http://doc.qt.io/qt-5/qversionnumber.html" \
class="remarkup-link" target="_blank" \
rel="noreferrer">http://doc.qt.io/qt-5/qversionnumber.html</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4193" \
rel="noreferrer">https://phabricator.kde.org/D4193</a></div></div><br \
/><div><strong>To: </strong>arichardson, Plasma<br /><strong>Cc: \
</strong>anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]