[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5399: Allow to edit system color schemes
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-04-11 18:08:53
Message-ID: 20170411180742.10047.7913.FEA46680 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  This patch breaks the "Defaults" button as it will reset the index, but you'll \
still have your custom changes.  
  I don't see how this patch solves anything, previously you could edit a global \
scheme and the workflow was just as easy; you click Edit, the only difference is you \
had to give it a new name.

INLINE COMMENTS

> colorscm.cpp:164
> schemeRemoveButton->setEnabled(false);
> schemeEditButton->setEnabled(false);
> 

This patch doesn't actually address the actual issue that I know you were trying to \
fix - this line.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5399

To: mart, #plasma
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5399" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>This patch breaks the \
&quot;Defaults&quot; button as it will reset the index, but you&#039;ll still have \
your custom changes.</p>

<p>I don&#039;t see how this patch solves anything, previously you could edit a \
global scheme and the workflow was just as easy; you click Edit, the only difference \
is you had to give it a new name.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5399#inline-22139" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">colorscm.cpp:164</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span class="n">schemeRemoveButton</span><span style="color: \
#aa2211">-&gt;</span><span class="n">setEnabled</span><span class="p">(</span><span \
style="color: #304a96">false</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">            <span \
class="n">schemeEditButton</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setEnabled</span><span class="p">(</span><span style="color: \
#304a96">false</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
patch doesn&#039;t actually address the actual issue that I know you were trying to \
fix - this line.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5399" \
rel="noreferrer">https://phabricator.kde.org/D5399</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]