[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5355: Fix query for available modules
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-04-09 22:11:41
Message-ID: 20170409221141.3643.7905.EF11D530 () phabricator ! kde ! org
[Download RAW message or body]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.cpp:62
> +    // We need the exist calls because otherwise the trader language aborts if the \
> property doesn't exist and the second part of the or is not evaluated +    const \
> KService::List services = KServiceTypeTrader::self()->query( "KCModule", "(exist \
> [X-KDE-System-Settings-Parent-Category] and [X-KDE-System-Settings-Parent-Category] \
> != '') or (exist [X-KDE-ParentApp] and [X-KDE-ParentApp] == 'kinfocenter')" ); for( \
> KService::List::const_iterator it = services.constBegin(); it != \
> services.constEnd(); ++it) {

Use QStringLiteral()?

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D5355

To: aacid, apol
Cc: apol, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas


[Attachment #3 (text/html)]

<table><tr><td style="">apol accepted this revision.<br />apol added inline \
comments.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5355" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5355#inline-22030" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:62</span></div> \
<div style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, \
&quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);">    <span style="color: #74777d">// We need the exist calls because \
otherwise the trader language aborts if the property doesn&#39;t exist and the second \
part of the or is not evaluated</span> </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#aa4000">const</span> <span class="n">KService</span><span style="color: \
#aa2211">::</span><span class="n">List</span> <span class="n">services</span> <span \
style="color: #aa2211">=</span> <span class="n">KServiceTypeTrader</span><span \
style="color: #aa2211">::</span><span class="n">self</span><span \
class="p">()</span><span style="color: #aa2211">-&gt;</span><span \
class="n">query</span><span class="p">(</span> <span style="color: \
#766510">&quot;KCModule&quot;</span><span class="p">,</span> <span style="color: \
#766510">&quot;(exist [X-KDE-System-Settings-Parent-Category] and \
[X-KDE-System-Settings-Parent-Category] != &#39;&#39;) or (exist [X-KDE-ParentApp] \
and [X-KDE-ParentApp] == &#39;kinfocenter&#39;)&quot;</span> <span \
class="p">);</span> </div><div style="padding: 0 8px; margin: 0 4px; ">    <span \
style="color: #aa4000">for</span><span class="p">(</span> <span \
class="n">KService</span><span style="color: #aa2211">::</span><span \
class="n">List</span><span style="color: #aa2211">::</span><span \
class="n">const_iterator</span> <span class="n">it</span> <span style="color: \
#aa2211">=</span> <span class="n">services</span><span class="p">.</span><span \
class="n">constBegin</span><span class="p">();</span> <span class="n">it</span> <span \
style="color: #aa2211">!=</span> <span class="n">services</span><span \
class="p">.</span><span class="n">constEnd</span><span class="p">();</span> <span \
style="color: #aa2211">++</span><span class="n">it</span><span class="p">)</span> \
<span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use \
QStringLiteral()?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R126 KDE CLI \
Utilities</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.8</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5355" \
rel="noreferrer">https://phabricator.kde.org/D5355</a></div></div><br \
/><div><strong>To: </strong>aacid, apol<br /><strong>Cc: </strong>apol, plasma-devel, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]