From kde-panel-devel  Fri Mar 31 20:33:10 2017
From: Aditya Mehra <noreply () phabricator ! kde ! org>
Date: Fri, 31 Mar 2017 20:33:10 +0000
To: kde-panel-devel
Subject: D5264: Amarok Player Integration For Mycroft
Message-Id: <20170331203309.52662.46632.8E8AB9C3 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=149099240514381
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--f05f8125fab14681b644b021b75e18c3"

--f05f8125fab14681b644b021b75e18c3
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Aiix added a comment.


  In https://phabricator.kde.org/D5264#99248, @graesslin wrote:
 =20
  > Just wondering: why dedicated to amarok instead of interacting with mpr=
is? That would allow to control any media player instead of just amarok
 =20
 =20
  Amarok is the first implementation of interacting  over the default mpris=
 dbus interface where other players over the mpris dbus interface will be a=
dded, The limitation seems to be on the side of how I can integrate with My=
croft Skills via Dbus and intent management. There are two points to this. =
1. It seems currently i cannot implement a blocking dbus loop on a mycroft =
skill where i cannot directly query the media player in use by the system i=
n default this will break user interaction with other skills if i run the s=
kill in a dbus main loop so only single method calls work without having th=
e ability to implement dbus signals and replies.  2. Intent handling for ex=
ample user say's simply "Play Music / Pause Music / Next Song / Previous So=
ng" how to determine the media player to use by default as every user has a=
n individual preference unless it is being defined by the system where ther=
e is a dbus method call to a default system player available. Here the solu=
tion as per my implementation seems to segregate the media player the user =
wants to play his media by where any media player  for example "Babe Qt", "=
Rhythmbox" "Deepin Media Player" or "VLC" that makes use of mpris dbus inte=
rface will have individual intent calls like "Hey Mycroft, Deepin Play Song=
" or "Hey Mycroft, Rhythmbox Play Song" etc.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D5264

To: Aiix
Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuter=
berg, abetts, sebas, apol

--f05f8125fab14681b644b021b75e18c3
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">Aiix added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D5264" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><blockquote style=3D"border-left: 3px solid #8=
C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style=3D"font-style: normal;
          padding-bottom: 4px;">In <a href=3D"https://phabricator.kde.org/D=
5264#99248" style=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" rel=3D"noreferrer">D=
5264#99248</a>, <a href=3D"https://phabricator.kde.org/p/graesslin/" style=
=3D"
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel=3D"noreferrer">@graesslin</a> wrote:</=
div>
<div style=3D"margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Just wondering: why dedicated to a=
marok instead of interacting with mpris? That would allow to control any me=
dia player instead of just amarok</p></div>
</blockquote>

<p>Amarok is the first implementation of interacting  over the default mpri=
s dbus interface where other players over the mpris dbus interface will be =
added, The limitation seems to be on the side of how I can integrate with M=
ycroft Skills via Dbus and intent management. There are two points to this.=
 1. It seems currently i cannot implement a blocking dbus loop on a mycroft=
 skill where i cannot directly query the media player in use by the system =
in default this will break user interaction with other skills if i run the =
skill in a dbus main loop so only single method calls work without having t=
he ability to implement dbus signals and replies.  2. Intent handling for e=
xample user say&#039;s simply &quot;Play Music / Pause Music / Next Song / =
Previous Song&quot; how to determine the media player to use by default as =
every user has an individual preference unless it is being defined by the s=
ystem where there is a dbus method call to a default system player availabl=
e. Here the solution as per my implementation seems to segregate the media =
player the user wants to play his media by where any media player  for exam=
ple &quot;Babe Qt&quot;, &quot;Rhythmbox&quot; &quot;Deepin Media Player&qu=
ot; or &quot;VLC&quot; that makes use of mpris dbus interface will have ind=
ividual intent calls like &quot;Hey Mycroft, Deepin Play Song&quot; or &quo=
t;Hey Mycroft, Rhythmbox Play Song&quot; etc.</p></div></div><br /><div><st=
rong>REPOSITORY</strong><div><div>R846 Mycroft Plasma integration</div></di=
v></div><br /><div><strong>REVISION DETAIL</strong><div><a href=3D"https://=
phabricator.kde.org/D5264" rel=3D"noreferrer">https://phabricator.kde.org/D=
5264</a></div></div><br /><div><strong>To: </strong>Aiix<br /><strong>Cc: <=
/strong>graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensre=
uterberg, abetts, sebas, apol<br /></div>
--f05f8125fab14681b644b021b75e18c3--