[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5262: Animate quick tiling outline
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-03-31 13:29:40
Message-ID: differential-rev-PHID-DREV-cxyglgv4kwpvsjil6s3f-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  When quick tiling animate the outline from the window geometry to the position it \
would have afterwards.  This provides a visual hint to from where to where the window \
will go.

TEST PLAN
  The outline window size is a union of target and destination size and the animation \
itself is done in QML, ie. no window position is animated.  Due to this, when the \
outline is already shown (e.g. dragging the window along a side of the screen) it \
jumps into new position without an animation like before.  Also, in order to \
facilitate the initial animation, it first calls show() on the outline and then sets \
active true after which QML will animate.  The non-composited outline is unchanged.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5262

AFFECTED FILES
  geometry.cpp
  outline.cpp
  outline.h
  qml/outline/plasma/outline.qml

To: broulik, #plasma, #kwin
Cc: plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: KWin.<br />Restricted Application added subscribers: kwin, \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5262" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>When \
quick tiling animate the outline from the window geometry to the position it would \
have afterwards.<br /> This provides a visual hint to from where to where the window \
will go.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>The outline \
window size is a union of target and destination size and the animation itself is \
done in QML, ie. no window position is animated.<br /> Due to this, when the outline \
is already shown (e.g. dragging the window along a side of the screen) it jumps into \
new position without an animation like before.<br /> Also, in order to facilitate the \
initial animation, it first calls show() on the outline and then sets active true \
after which QML will animate.<br /> The non-composited outline is \
unchanged.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5262" \
rel="noreferrer">https://phabricator.kde.org/D5262</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>geometry.cpp<br /> outline.cpp<br />
outline.h<br />
qml/outline/plasma/outline.qml</div></div></div><br /><div><strong>To: \
</strong>broulik, Plasma, KWin<br /><strong>Cc: </strong>plasma-devel, kwin, \
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]