[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D3498: Add scaling to DRM backend
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-03-31 10:28:57
Message-ID: 20170331102857.39256.75280.EC10E7C2 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> subdiff wrote in drm_output.cpp:104
> Instead of dividing on every call, declare new private variable `QSize m_scaledSize \
> = pixelSize() / scale()`, and update its value only when m_mode or the scale value \
> is changed.

What benefit will that have?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D3498

To: davidedmundson, graesslin, subdiff, #plasma
Cc: subdiff, #kwin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3498" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D3498#inline-21674" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">subdiff</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">drm_output.cpp:104</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Instead of dividing on every \
call, declare new private variable <tt style="background: #ebebeb; font-size: \
13px;">QSize m_scaledSize = pixelSize() / scale()</tt>, and update its value only \
when m_mode or the scale value is changed.</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">What benefit will that \
have?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3498" \
rel="noreferrer">https://phabricator.kde.org/D3498</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, graesslin, subdiff, Plasma<br \
/><strong>Cc: </strong>subdiff, KWin, plasma-devel, kwin, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]