[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5250: cursors: Make build scripts more generic; build more sizes
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2017-03-30 17:55:45
Message-ID: 20170330175544.34026.11680.C51ED135 () phabricator ! kde ! org
[Download RAW message or body]

subdiff added a comment.


  Yea, this fixed the problem. Great!
  
  I built it and installed the cursors now. They are also all correctly listed in the \
cursortheme KCM (`kcmshell5 cursortheme`) and I was able to select them all \
individually. I've seen only two problems :  
  - On auto resolution it selects size 32px for my 1.5 scaled display, although it \
should be 36px. But this is probably in KWin, still we shouldn't forget about it (if \
you are interested in how it works grep "themeSize" in KWin's source and "cursorSize" \
                in Plasma Desktop's source).
  - When using auto resolution the mouse movement seemed to me in fact somewhat more \
sluggish when before with only  3 sizes, but this might be an illusion. Did you try \
your patch on a slower machine?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5250

To: jamesl, #plasma
Cc: subdiff, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5250" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Yea, this fixed the problem. Great!</p>

<p>I built it and installed the cursors now. They are also all correctly listed in \
the cursortheme KCM (<tt style="background: #ebebeb; font-size: 13px;">kcmshell5 \
cursortheme</tt>) and I was able to select them all individually. I&#039;ve seen only \
two problems :</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">On auto resolution it selects size 32px for my 1.5 \
scaled display, although it should be 36px. But this is probably in KWin, still we \
shouldn&#039;t forget about it (if you are interested in how it works grep \
&quot;themeSize&quot; in KWin&#039;s source and &quot;cursorSize&quot; in Plasma \
Desktop&#039;s source).</li> <li class="remarkup-list-item">When using auto \
resolution the mouse movement seemed to me in fact somewhat more sluggish when before \
with only  3 sizes, but this might be an illusion. Did you try your patch on a slower \
machine?</li> </ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 \
Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5250" \
rel="noreferrer">https://phabricator.kde.org/D5250</a></div></div><br \
/><div><strong>To: </strong>jamesl, Plasma<br /><strong>Cc: </strong>subdiff, \
plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]