[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5255: [Task Manager] Keep entry highlighted when context menu or group dialog is open
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-03-30 11:57:39
Message-ID: differential-rev-PHID-DREV-qw4d4i3pwj6q2aio4piw-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes it easier to see what item the menu or popup is for.
  In fact, the item should have stayed highlighted when the context menu is open but \
this was broken.  Also, for consistency, use the hover effect also for the group \
dialog (it used to be the "active" task).

TEST PLAN
  Context menu open but mouse cursor outside of task item
  F3439176: Screenshot_20170330_135657.png <https://phabricator.kde.org/F3439176>
  Group dialog
  F3439196: Screenshot_20170330_135728.png <https://phabricator.kde.org/F3439196>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5255

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5255" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
makes it easier to see what item the menu or popup is for.<br /> In fact, the item \
should have stayed highlighted when the context menu is open but this was broken.<br \
/> Also, for consistency, use the hover effect also for the group dialog (it used to \
be the &quot;active&quot; task).</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Context menu open but mouse cursor outside of task item<br /> <a \
href="https://phabricator.kde.org/F3439176" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F3439176: \
Screenshot_20170330_135657.png</a><br /> Group dialog<br />
<a href="https://phabricator.kde.org/F3439196" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F3439196: \
Screenshot_20170330_135728.png</a></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5255" \
rel="noreferrer">https://phabricator.kde.org/D5255</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/taskmanager/package/contents/ui/Task.qml</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, VDG, hein<br /><strong>Cc: \
</strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]