[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D5245: Desaturate non-responsive windows
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2017-03-29 21:20:24
Message-ID: 20170329212024.53220.89344.ED9A6D32 () phabricator ! kde ! org
[Download RAW message or body]
broulik updated this revision to Diff 12992.
broulik edited the test plan for this revision.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Base frozenapp effect on dialogparent code, this fixes minimizing of frozen \
windows and also switching desktop (properly cancels and reapplies \
animation)
- Use lambda instead of sender() cast
- Adjust effectloader unittest
- Add "unresponsive" property to effect window (accessible from effect script)
- Manipulate caption() directly instead of doing that in deco (shows up in Alt+Tab \
now also)
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5245?vs=12983&id=12992
REVISION DETAIL
https://phabricator.kde.org/D5245
AFFECTED FILES
abstract_client.cpp
abstract_client.h
autotests/test_scripted_effectloader.cpp
client.cpp
effects.cpp
effects/CMakeLists.txt
effects/frozenapp/CMakeLists.txt
effects/frozenapp/package/CMakeLists.txt
effects/frozenapp/package/contents/code/main.js
effects/frozenapp/package/metadata.desktop
libkwineffects/kwineffects.cpp
libkwineffects/kwineffects.h
To: broulik, #vdg, graesslin, #kwin, #plasma
Cc: luebking, kvermette, graesslin, plasma-devel, kwin, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">broulik updated this revision to Diff 12992.<br />broulik \
edited the test plan for this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-gqtz56yri4vk3xn/" \
rel="noreferrer">(Show Details)</a><br />broulik added a comment.<br />Restricted \
Application edited projects, added KWin; removed Plasma. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5245" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Base frozenapp effect on \
dialogparent code, this fixes minimizing of frozen windows and also switching desktop \
(properly cancels and reapplies animation)</li> <li class="remarkup-list-item">Use \
lambda instead of sender() cast</li> <li class="remarkup-list-item">Adjust \
effectloader unittest</li> <li class="remarkup-list-item">Add \
"unresponsive" property to effect window (accessible from effect \
script)</li> <li class="remarkup-list-item">Manipulate caption() directly instead of \
doing that in deco (shows up in Alt+Tab now also)</li> </ul></div></div><br \
/><div><strong>CHANGES TO TEST PLAN</strong><div><div style="white-space: pre-wrap; \
color: #74777D;"><div style="padding: 8px 0;">...</div>* Running the timer twice is \
probably more of a hack, when the client is already marked unresponsive, which halves \
the timeout when the kill dialog is triggered on subsequent invocations<span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);"><br /> \
<br /> {F3429932}<br />
<br />
Screenshots of a less colorful app (always 10% Saturation), proposals:<br />
125% Brightness (original attempt)<br />
{F3431234}<br />
80% Brightness (I don't really like this, looks mostly like the "dialog \
parent" effect; while this somewhat teaches people "dark window cannot be \
interacted with", I don't like it :p)</span><br /> <span style="padding: 0 \
2px; color: #333333; background: rgba(251, 175, 175, .7);">* Not sure about the \
"(Not Responding)" part in title bar (also do we have Message.sh for \
deco?), I chose not to manipulate the client's caption but do it only in the \
decoration.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, \
234, 151, .6);">{F3431316}<br /> 150% Brightness (my favorite,</span> <span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">Maybe we \
can improve the look</span><span style="padding: 0 2px; color: #333333; background: \
rgba(151, 234, 151, .6);">implemented in this updated patch</span>, <span \
style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">even?<br \
/> <br />
{F3429932}</span><span style="padding: 0 2px; color: #333333; background: rgba(151, \
234, 151, .6);">causes separator lines to fully wash out)</span><br /> <span \
style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, \
.6);">{F3431546}</span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D5245?vs=12983&id=12992" \
rel="noreferrer">https://phabricator.kde.org/D5245?vs=12983&id=12992</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5245" \
rel="noreferrer">https://phabricator.kde.org/D5245</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>abstract_client.cpp<br /> \
abstract_client.h<br /> autotests/test_scripted_effectloader.cpp<br />
client.cpp<br />
effects.cpp<br />
effects/CMakeLists.txt<br />
effects/frozenapp/CMakeLists.txt<br />
effects/frozenapp/package/CMakeLists.txt<br />
effects/frozenapp/package/contents/code/main.js<br />
effects/frozenapp/package/metadata.desktop<br />
libkwineffects/kwineffects.cpp<br />
libkwineffects/kwineffects.h</div></div></div><br /><div><strong>To: \
</strong>broulik, VDG, graesslin, KWin, Plasma<br /><strong>Cc: </strong>luebking, \
kvermette, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic