[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D5245: Desaturate non-responsive windows
From: Martin_Gräßlin <noreply () phabricator ! kde ! org>
Date: 2017-03-29 16:12:03
Message-ID: 20170329161202.42883.57238.0FFBB5B3 () phabricator ! kde ! org
[Download RAW message or body]
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please adjust the autotests/test_*_effectloader.cpp - they would fail as you added \
an effect. Also please try running all autotests, we have some tests for the kill \
timeout, so your change might affect those.
INLINE COMMENTS
> decoratedclient.cpp:138-146
> +QString DecoratedClientImpl::caption() const
> +{
> + QString caption = m_client->caption();
> + if (m_client->unresponsive()) {
> + caption += i18nc("Application is not responding, appended to window \
> title", " (Not Responding)"); + }
> + return caption;
instead of moving this into the decoration plugin, you could just adjust the caption \
directly. We already manipulate it anyway for adding things like (2). The advantage \
is that it would be available everywhere where we use the caption. E.g. Alt+Tab, \
PresentWindows...
> effects.cpp:540
> +{
> + emit windowUnresponsiveChanged(static_cast<Client*>(sender())->effectWindow(), \
> unresponsive); +}
no cast on sender in new code please. We don't need this with lambda captures.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5245
To: broulik, #plasma, #kwin, #vdg, graesslin
Cc: graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5245" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please adjust the \
autotests/test_*_effectloader.cpp - they would fail as you added an effect. Also \
please try running all autotests, we have some tests for the kill timeout, so your \
change might affect those.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5245#inline-21600" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">decoratedclient.cpp:138-146</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span \
class="bright"></span><span class="n"><span \
class="bright">DELEGATE2</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="n">QString<span \
class="bright"></span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span \
class="n">caption<span class="bright"></span></span><span class="bright"></span><span \
class="p"><span class="bright">)</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">QString<span \
class="bright"></span></span><span class="bright"> </span><span class="n"><span \
class="bright">DecoratedClientImpl</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">::</span></span><span \
class="n">caption<span class="bright"></span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa4000"><span class="bright">const</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span \
class="n">caption</span> <span style="color: #aa2211">=</span> <span \
class="n">m_client</span><span style="color: #aa2211">-></span><span \
class="n">caption</span><span class="p">();</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">if</span> <span class="p">(</span><span class="n">m_client</span><span \
style="color: #aa2211">-></span><span class="n">unresponsive</span><span \
class="p">())</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">caption</span> <span style="color: #aa2211">+=</span> <span \
class="n">i18nc</span><span class="p">(</span><span style="color: \
#766510">"Application is not responding, appended to window \
title"</span><span class="p">,</span> <span style="color: #766510">" (Not \
Responding)"</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">return</span> <span \
class="n">caption</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">instead of moving this into the decoration plugin, you could just adjust the \
caption directly. We already manipulate it anyway for adding things like (2). The \
advantage is that it would be available everywhere where we use the caption. E.g. \
Alt+Tab, PresentWindows...</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5245#inline-21602" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">effects.cpp:540</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"><span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
class="n">emit</span> <span class="n">windowUnresponsiveChanged</span><span \
class="p">(</span><span style="color: #aa4000">static_cast</span><span style="color: \
#aa2211"><</span><span class="n">Client</span><span style="color: \
#aa2211">*></span><span class="p">(</span><span class="n">sender</span><span \
class="p">())</span><span style="color: #aa2211">-></span><span \
class="n">effectWindow</span><span class="p">(),</span> <span \
class="n">unresponsive</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">no cast on sender in new code please. We don't need this with \
lambda captures.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5245" \
rel="noreferrer">https://phabricator.kde.org/D5245</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, KWin, VDG, graesslin<br /><strong>Cc: \
</strong>graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic