[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5232: Add override to methods that override methods on their parent class
From:       Martin_Gräßlin <noreply () phabricator ! kde ! org>
Date:       2017-03-29 14:52:57
Message-ID: 20170329145255.113852.67452.C5DF1E08 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D5232#98698, @apol wrote:
  
  > In https://phabricator.kde.org/D5232#98689, @graesslin wrote:
  >
  > > I would prefer if this IMHO useless warning gets disabled.
  >
  >
  > `override` adds useful semantics to your code, that's never useless.
  >
  > Oh well...
  
  
  A warning which breaks the warning output of legacy code (and that's what KWin is) \
is completely useless. Yes override is cool and useful. And KWin uses it in new code. \
But adjusting the old code - no that just makes the git history a mess. Nobody \
touches that code, nobody will change it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5232

To: apol, #plasma, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5232" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5232#98698" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D5232#98698</a>, <a href="https://phabricator.kde.org/p/apol/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@apol</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D5232#98689" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;" \
rel="noreferrer">D5232#98689</a>, <a href="https://phabricator.kde.org/p/graesslin/" \
style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@graesslin</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I would prefer if this IMHO useless warning \
gets disabled.</p></div> </blockquote>

<p><tt style="background: #ebebeb; font-size: 13px;">override</tt> adds useful \
semantics to your code, that&#039;s never useless.</p>

<p>Oh well...</p></div>
</blockquote>

<p>A warning which breaks the warning output of legacy code (and that&#039;s what \
KWin is) is completely useless. Yes override is cool and useful. And KWin uses it in \
new code. But adjusting the old code - no that just makes the git history a mess. \
Nobody touches that code, nobody will change it.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5232" \
rel="noreferrer">https://phabricator.kde.org/D5232</a></div></div><br \
/><div><strong>To: </strong>apol, Plasma, graesslin, davidedmundson<br /><strong>Cc: \
</strong>luebking, plasma-devel, kwin, KWin, progwolff, lesliezhai, ali-mohamed, \
hardening, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]