[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5221: [desktop:/ KIO] Add descriptive name for root item
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2017-03-29 7:12:01
Message-ID: 20170329071159.42722.20507.6D01A318 () phabricator ! kde ! org
[Download RAW message or body]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_desktop.cpp:171
> +    // Set a descriptive display name for the root item
> +    if (entry.stringValue(KIO::UDSEntry::UDS_NAME) == QLatin1String(".")) {
> +        entry.insert(KIO::UDSEntry::UDS_DISPLAY_NAME, i18n("Desktop Folder"));

This will be wrong in subdirs of desktop:/, as you mentioned in the description, no?

You can do if (requestedUrl().path() == "/" && ....)
where requestedUrl() is a method from the base class ForwardingSlaveBase.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5221

To: broulik, #plasma, hein, dfaure, elvisangelaccio
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Attachment #3 (text/html)]

<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added \
inline comments.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5221" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D5221#inline-21568" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kio_desktop.cpp:171</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: \
#74777d">// Set a descriptive display name for the root item</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">entry</span><span class="p">.</span><span class="n">stringValue</span><span \
class="p">(</span><span class="n">KIO</span><span style="color: \
#aa2211">::</span><span class="n">UDSEntry</span><span style="color: \
#aa2211">::</span><span class="n">UDS_NAME</span><span class="p">)</span> <span \
style="color: #aa2211">==</span> <span class="n">QLatin1String</span><span \
class="p">(</span><span style="color: #766510">&quot;.&quot;</span><span \
class="p">))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span \
class="n">entry</span><span class="p">.</span><span class="n">insert</span><span \
class="p">(</span><span class="n">KIO</span><span style="color: \
#aa2211">::</span><span class="n">UDSEntry</span><span style="color: \
#aa2211">::</span><span class="n">UDS_DISPLAY_NAME</span><span class="p">,</span> \
<span class="n">i18n</span><span class="p">(</span><span style="color: \
#766510">&quot;Desktop Folder&quot;</span><span class="p">));</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This will be wrong in subdirs of desktop:/, as you mentioned in the \
description, no?</p>

<p style="padding: 0; margin: 8px;">You can do if (requestedUrl().path() == \
&quot;/&quot; &amp;&amp; ....)<br /> where requestedUrl() is a method from the base \
class ForwardingSlaveBase.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5221" \
rel="noreferrer">https://phabricator.kde.org/D5221</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein, dfaure, elvisangelaccio<br \
/><strong>Cc: </strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]