[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5109: [Kicker/App Entry] Try QIcon with path if no theme icon is found
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-03-19 22:25:46
Message-ID: differential-rev-PHID-DREV-fpfhxlgkrpsmmvgsnpu6-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Applications can specify an absolute file path for an icon which won't work with \
QIcon::fromTheme.  If a theme icon isn't find, first try to load it using an absolute \
path before falling back to an unknown icon.  
  BUG: 365131

TEST PLAN
  5.9 branch?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5109

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5109" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Applications can specify an absolute file path for an icon \
which won&#039;t work with QIcon::fromTheme.<br /> If a theme icon isn&#039;t find, \
first try to load it using an absolute path before falling back to an unknown \
icon.</p>

<p>BUG: 365131</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>5.9 \
branch?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma \
Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5109" \
rel="noreferrer">https://phabricator.kde.org/D5109</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>applets/kicker/plugin/appentry.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, hein<br /><strong>Cc: \
</strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]