[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D4939: Get rid of KDELibs4Support
From:       Alexander Volkov <noreply () phabricator ! kde ! org>
Date:       2017-03-17 10:52:57
Message-ID: 20170317105257.25914.47725.C71935A1 () phabricator ! kde ! org
[Download RAW message or body]

volkov added a comment.


  Looks good to me.
  
  powerdevilpowermanagement.{h,cpp} should be extracted into a library, but it can be \
done in a separate commit.  Since they deal with org.freedesktop.PowerManagement \
interface which is obsolete and implemented only by  PowerDevil, I suppose such a \
library should be a part of PowerDevil.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4939

To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">volkov added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4939" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Looks good to me.</p>

<p>powerdevilpowermanagement.{h,cpp} should be extracted into a library, but it can \
be done in a separate commit.<br /> Since they deal with \
org.freedesktop.PowerManagement interface which is obsolete and implemented only \
by<br /> PowerDevil, I suppose such a library should be a part of \
PowerDevil.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R122 \
Powerdevil</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4939" \
rel="noreferrer">https://phabricator.kde.org/D4939</a></div></div><br \
/><div><strong>To: </strong>denisshienkov, volkov, afiestas<br /><strong>Cc: \
</strong>graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]