[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5034: Add support for x-gvfs style options in fstab
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-03-13 14:28:57
Message-ID: differential-rev-PHID-DREV-6cwagq2jheowulk2lcac-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  These fstab options allows an administrator to specify names and icons intended for \
the user, shown in a GUI.  
  For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt


TEST PLAN
  This is a frameworks port and cleanup of https://git.reviewboard.kde.org/r/113587
  
  Placed the following in `/etc/fstab`
  
    hostname:/ /mnt/ nfs4 \
defaults,_netdev,user,rw,exec,comment=x-gvfs-show,x-gvfs-name=Test%20Folder,x-gvfs-icon=folder-home,timeo=14,noatime \
0 0  
  Got the following entry:
  F2800877: Screenshot_20170313_152729.png <https://phabricator.kde.org/F2800877>
  Also verified that `comment=x-gvfs-hide` hides the entry. I did not implement \
`x-gvfs-show` as we always show all devices no matter where they are, so the override \
to forcefully show it is of no use to us.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h

To: broulik, #plasma, dfaure
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: \
Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5034" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>These \
fstab options allows an administrator to specify names and icons intended for the \
user, shown in a GUI.</p>

<p>For details, see <a \
href="https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt</a></p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>This is a frameworks port and cleanup of <a \
href="https://git.reviewboard.kde.org/r/113587" class="remarkup-link" target="_blank" \
rel="noreferrer">https://git.reviewboard.kde.org/r/113587</a></p>

<p>Placed the following in <tt style="background: #ebebeb; font-size: \
13px;">/etc/fstab</tt></p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">hostname:/ /mnt/ nfs4 \
defaults,_netdev,user,rw,exec,comment=x-gvfs-show,x-gvfs-name=Test%20Folder,x-gvfs-icon=folder-home,timeo=14,noatime \
0 0</pre></div>

<p>Got the following entry:<br />
<a href="https://phabricator.kde.org/F2800877" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F2800877: \
Screenshot_20170313_152729.png</a><br /> Also verified that <tt style="background: \
#ebebeb; font-size: 13px;">comment=x-gvfs-hide</tt> hides the entry. I did not \
implement <tt style="background: #ebebeb; font-size: 13px;">x-gvfs-show</tt> as we \
always show all devices no matter where they are, so the override to forcefully show \
it is of no use to us.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R245 Solid</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5034" \
rel="noreferrer">https://phabricator.kde.org/D5034</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/solid/devices/backends/fstab/fstabdevice.cpp<br /> \
src/solid/devices/backends/fstab/fstabdevice.h<br /> \
src/solid/devices/backends/fstab/fstabhandling.cpp<br /> \
src/solid/devices/backends/fstab/fstabhandling.h<br /> \
src/solid/devices/backends/fstab/fstabstorageaccess.cpp<br /> \
src/solid/devices/backends/fstab/fstabstorageaccess.h</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, dfaure<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]