[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129994: Fix AppMenuApplet Called C++ object pointer is null
From: Leslie Zhai <xiangzhai83 () gmail ! com>
Date: 2017-03-09 1:43:32
Message-ID: 20170309014332.27981.53286 () mimi ! kde ! org
[Download RAW message or body]
--===============6252174791718372403==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129994/
-----------------------------------------------------------
(Updated March 8, 2017, 6:43 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Kai Uwe Broulik and David Edmundson.
Changes
-------
Submitted with commit 2b7ef97f8104db6212e2a75d2578c6edca96e05a by Leslie Zhai to \
branch master.
Repository: plasma-workspace
Description
-------
Hi KDE developer,
Bug reported by the clang static analyzer.
Description: Called C++ object pointer is null
File: plasma-workspace/applets/appmenu/lib/appmenuapplet.cpp
Line: 167
```
153 void AppMenuApplet::trigger(QQuickItem *ctx, int idx)
154 {
155 if (m_currentIndex == idx) {
Taking false branch
?
156 return;
157 }
158
159 QMenu *actionMenu = createMenu(idx);
160 if (actionMenu) {
?
Assuming 'actionMenu' is non-null
?
?
Taking true branch
?
161
162 if (ctx && ctx->window() && ctx->window()->mouseGrabberItem()) {
4
?
Assuming 'ctx' is null
?
163 // FIXME event forge thing enters press and hold move mode :/
164 ctx->window()->mouseGrabberItem()->ungrabMouse();
165 }
166
167 const auto &geo = ctx->window()->screen()->availableVirtualGeometry();
5
?
Called C++ object pointer is null
```
So I simply add some checker for ctx, ctx->window() and ctx->window()->screen() \
pointers.
Regards,
Leslie Zhai
Diffs
-----
applets/appmenu/lib/appmenuapplet.cpp 9aaf5cc6
Diff: https://git.reviewboard.kde.org/r/129994/diff/
Testing
-------
Thanks,
Leslie Zhai
--===============6252174791718372403==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129994/">https://git.reviewboard.kde.org/r/129994/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik and David Edmundson.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated March 8, 2017, 6:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2b7ef97f8104db6212e2a75d2578c6edca96e05a by Leslie \
Zhai to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi KDE developer,</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug \
reported by the clang static analyzer.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Description: Called C++ \
object pointer is null
File: plasma-workspace/applets/appmenu/lib/appmenuapplet.cpp
Line: 167</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span></span>153 void \
AppMenuApplet::trigger(QQuickItem *ctx, int idx) 154 {
155 if (m_currentIndex == idx) {
Taking false branch
?
156 return;
157 }
158
159 QMenu *actionMenu = createMenu(idx);
160 if (actionMenu) {
?
Assuming 'actionMenu' is non-null
?
?
Taking true branch
?
161
162 if (ctx && ctx->window() && \
ctx->window()->mouseGrabberItem()) { 4
?
Assuming 'ctx' is null
?
163 // FIXME event forge thing enters press and hold move mode :/
164 ctx->window()->mouseGrabberItem()->ungrabMouse();
165 }
166
167 const auto &geo = \
ctx->window()->screen()->availableVirtualGeometry(); 5
?
Called C++ object pointer is null
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So I simply add some checker for ctx, ctx->window() \
and ctx->window()->screen() pointers.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards, Leslie \
Zhai</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/appmenu/lib/appmenuapplet.cpp <span style="color: \
grey">(9aaf5cc6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129994/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6252174791718372403==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic