[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129995: Fix KillRunner Memory leak
From: Leslie Zhai <xiangzhai83 () gmail ! com>
Date: 2017-03-08 2:43:58
Message-ID: 20170308024358.27981.52622 () mimi ! kde ! org
[Download RAW message or body]
--===============2401118357134179939==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129995/
-----------------------------------------------------------
(Updated March 8, 2017, 2:43 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik.
Changes
-------
Submitted with commit 55237430bdab1bfbbfb442281ca5e34f5eb5e212 by Leslie Zhai to \
branch master.
Repository: plasma-workspace
Description
-------
Hi KDE developers,
Bug reported by the clang static analyzer.
Description: Potential leak of memory pointed to by 'process'
File: plasma-workspace/runners/kill/killrunner.cpp
Line: 186
```
168 void KillRunner::run(const Plasma::RunnerContext &context, const \
Plasma::QueryMatch &match) 169 {
170 Q_UNUSED(context)
171
172 QVariantList data = match.data().value<QVariantList>();
173 quint64 pid = data[0].toUInt();
174 // QString user = data[1].toString();
175
176 int signal;
177 if (match.selectedAction() != NULL) {
Assuming the condition is false
?
?
Taking false branch
?
178 signal = match.selectedAction()->data().toInt();
179 } else {
180 signal = 9; //default: SIGKILL
181 }
182
183 QStringList args;
184 args << QStringLiteral("-%1").arg(signal) << QStringLiteral("%1").arg(pid);
185 KProcess *process = new KProcess(this);
?
Memory is allocated
?
186 int returnCode = process->execute(QStringLiteral("kill"), args);
?
Within the expansion of the macro 'QStringLiteral':
a
Potential leak of memory pointed to by 'process'
187
188 if (returnCode == 0)
```
So I simply add ```delete process``` to free the allocated memory.
Regards,
Leslie Zhai
Diffs
-----
runners/kill/killrunner.cpp 5c2e8529
Diff: https://git.reviewboard.kde.org/r/129995/diff/
Testing
-------
Thanks,
Leslie Zhai
--===============2401118357134179939==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129995/">https://git.reviewboard.kde.org/r/129995/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Aleix Pol Gonzalez and Kai Uwe Broulik.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated March 8, 2017, 2:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 55237430bdab1bfbbfb442281ca5e34f5eb5e212 by Leslie \
Zhai to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi KDE developers,</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug \
reported by the clang static analyzer.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Description: Potential \
leak of memory pointed to by 'process'
File: plasma-workspace/runners/kill/killrunner.cpp
Line: 186</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%"><span></span>168 void KillRunner::run(const \
Plasma::RunnerContext &context, const Plasma::QueryMatch &match) 169 {
170 Q_UNUSED(context)
171
172 QVariantList data = match.data().value<QVariantList>();
173 quint64 pid = data[0].toUInt();
174 // QString user = data[1].toString();
175
176 int signal;
177 if (match.selectedAction() != NULL) {
Assuming the condition is false
?
?
Taking false branch
?
178 signal = match.selectedAction()->data().toInt();
179 } else {
180 signal = 9; //default: SIGKILL
181 }
182
183 QStringList args;
184 args << QStringLiteral("-%1").arg(signal) << \
QStringLiteral("%1").arg(pid); 185 KProcess *process = new \
KProcess(this);
?
Memory is allocated
?
186 int returnCode = process->execute(QStringLiteral("kill"), args);
?
Within the expansion of the macro 'QStringLiteral':
a
Potential leak of memory pointed to by 'process'
187
188 if (returnCode == 0)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So I simply add <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">delete process</code> to free the allocated memory.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Regards, Leslie Zhai</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/kill/killrunner.cpp <span style="color: grey">(5c2e8529)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129995/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2401118357134179939==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic