[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D4939: Get rid of KDELibs4Support
From: Denis Shienkov <noreply () phabricator ! kde ! org>
Date: 2017-03-07 19:29:51
Message-ID: 20170307192951.124563.50582.4C98E5B2 () phabricator ! kde ! org
[Download RAW message or body]
denisshienkov added inline comments.
INLINE COMMENTS
> denisshienkov wrote in activitypage.cpp:76
> > Why don't make QWeakPointer -> QPointer
>
>
>
> 1. Then, I suggest do not use QPointer at all, as it is overhead for this case. I \
> suggest to use the pointers directly..
> > commit first and base this one on it?
>
> I don't know how to do it with phabricator. It is my first issue in here. :)
> I don't know how to do it with phabricator. It is my first issue in here. :)
Please see https://phabricator.kde.org/D4970
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">denisshienkov added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4939" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20228" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">denisshienkov</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">activitypage.cpp:76</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p style="padding: 0; margin: 8px;">Why don't make QWeakPointer -> \
QPointer</p></blockquote>
<ol class="remarkup-list">
<li class="remarkup-list-item">Then, I suggest do not use QPointer at all, as it is \
overhead for this case. I suggest to use the pointers directly..</li> </ol>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">commit first and base this one on \
it?</p></blockquote>
<p style="padding: 0; margin: 8px;">I don't know how to do it with phabricator. \
It is my first issue in here. :)</p></div></div> <div style="margin: 8px 0; padding: \
0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; \
font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p style="padding: 0; margin: 8px;">I don't know how to do it with \
phabricator. It is my first issue in here. :)</p></blockquote>
<p style="padding: 0; margin: 8px;">Please see <a \
href="https://phabricator.kde.org/D4970" style="background-color: #e7e7e7; \
border-color: #e7e7e7; border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" \
rel="noreferrer">D4970</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4939" \
rel="noreferrer">https://phabricator.kde.org/D4939</a></div></div><br \
/><div><strong>To: </strong>denisshienkov, volkov, afiestas<br /><strong>Cc: \
</strong>graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic