[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D4939: Get rid of KDELibs4Support
From: Denis Shienkov <noreply () phabricator ! kde ! org>
Date: 2017-03-07 12:45:53
Message-ID: 20170307124553.6471.74015.8E0571DA () phabricator ! kde ! org
[Download RAW message or body]
denisshienkov added inline comments.
INLINE COMMENTS
> volkov wrote in CMakeLists.txt:111
> I guess it can be just removed. These kf5_org.* files were dropped from solid three \
> years ago.
Where I need to take an appropriate XML files then?
> volkov wrote in CMakeLists.txt:22
> Is it necessary to add KF5::Solid?
I will try later.
> volkov wrote in powerdevilcore.cpp:102
> And who will set backend for Core?
>
> Now I think that it was a bad idea to request supported suspend methods from a \
> backend, because GUI doesn't depend on it. You need to load the backend in GUI, it \
> will do some initialization...
> It seems to be more reasonable to request supported methods from powerdevil daemon \
> by dbus calllings org.freedesktop.PowerManagement.{CanSuspend, CanHibernate, \
> CanHybridSuspend}
> It seems to be more reasonable to request supported methods from powerdevil daemon \
> by dbus calllings
Ok, maybe then I can take a suggestion from @graesslin ?
"Just as an FYI: I reimplemented parts of the API in kscreenlocker. This code could \
be used here as well."
> volkov wrote in powerdevilcore.cpp:107
> unrelated
ok
> volkov wrote in activitypage.cpp:76
> Shouldn't it be in a separate change?
Then it does not compiled with Qt5 (without of KDELibs4Support).
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D4939
To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">denisshienkov added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4939" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20177" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">volkov</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:111</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">I guess it can be just removed. \
These kf5_org.* files were dropped from solid three years ago.</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Where I \
need to take an appropriate XML files then?</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D4939#inline-20178" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">volkov</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:22</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Is it necessary to add KF5::Solid?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">I will try \
later.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20186" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">volkov</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">powerdevilcore.cpp:102</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">And who will set backend \
for Core?</p>
<p style="padding: 0; margin: 8px;">Now I think that it was a bad idea to request \
supported suspend methods from a backend, <br /> because GUI doesn't depend on \
it. You need to load the backend in GUI, it will do some initialization...</p>
<p style="padding: 0; margin: 8px;">It seems to be more reasonable to request \
supported methods from powerdevil daemon by dbus calllings<br /> \
org.freedesktop.PowerManagement.{CanSuspend, CanHibernate, \
CanHybridSuspend}</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p \
style="padding: 0; margin: 8px;">It seems to be more reasonable to request supported \
methods from powerdevil daemon by dbus calllings</p></blockquote>
<p style="padding: 0; margin: 8px;">Ok, maybe then I can take a suggestion from <a \
href="https://phabricator.kde.org/p/graesslin/" style=" border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@graesslin</a> ?</p>
<p style="padding: 0; margin: 8px;">"Just as an FYI: I reimplemented parts of \
the API in kscreenlocker. This code could be used here as \
well."</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20187" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">volkov</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">powerdevilcore.cpp:107</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">unrelated</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">ok</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4939#inline-20188" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">volkov</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">activitypage.cpp:76</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">Shouldn't it be in a \
separate change?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">Then it does not compiled with Qt5 (without of \
KDELibs4Support).</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R122 Powerdevil</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4939" \
rel="noreferrer">https://phabricator.kde.org/D4939</a></div></div><br \
/><div><strong>To: </strong>denisshienkov, volkov, afiestas<br /><strong>Cc: \
</strong>graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic