[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons
From:       Aleix Pol Gonzalez <noreply () phabricator ! kde ! org>
Date:       2017-03-01 14:55:58
Message-ID: 20170301145558.121453.43663.E685067B () phabricator ! kde ! org
[Download RAW message or body]

apol added a comment.


  I think this patch needs more testing and getting it in was premature.
  One needs to be able to paste images and text as well.

INLINE COMMENTS

> main.qml:226
>      function action_paste() {
> +        if (clipboard.formats.length < 1) { // empty clipboard!
> +            return; // do nothing (there's the tooltip!)

This is not correct. What if the content isn't urls?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4805

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: yuenlim, #plasma, mart, apol
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Attachment #3 (text/html)]

<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4805" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I think this patch needs more testing and \
getting it in was premature.<br /> One needs to be able to paste images and text as \
well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4805#inline-19729" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">main.qml:226</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    \
<span style="color: #aa4000">function</span> <span style="color: \
#004012">action_paste</span><span class="p">()</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#004012">clipboard</span><span class="p">.</span><span style="color: \
#004012">formats</span><span class="p">.</span><span style="color: \
#004012">length</span> <span style="color: #aa2211">&lt;</span> <span style="color: \
#601200">1</span><span class="p">)</span> <span class="p">{</span> <span \
style="color: #74777d">// empty clipboard!</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;">            <span style="color: \
#aa4000">return</span><span class="p">;</span> <span style="color: #74777d">// do \
nothing (there&#39;s the tooltip!)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
is not correct. What if the content isn&#039;t \
urls?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4805" \
rel="noreferrer">https://phabricator.kde.org/D4805</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>yuenlim, Plasma, mart, apol<br /><strong>Cc: \
</strong>broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]