[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D4842: [System Tray] Listen to external collapse
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-03-01 13:12:03
Message-ID: 20170301131158.21189.74841.C55883CC () phabricator ! kde ! org
[Download RAW message or body]

mart added a comment.


  In https://phabricator.kde.org/D4842#90987, @broulik wrote:
  
  > Of course I meant the code in panel containment, but here it does expanded = \
false and that's what I wanted to listen to :)  >
  >   Plasmoid.onUserConfiguringChanged: {
  >       ...
  >           if (plasmoid.userConfiguring) {
  >               for (var i = 0; i < plasmoid.applets.length; ++i) {
  >                   plasmoid.applets[i].expanded = false;
  >               }
  >           ...
  >   }
  >
  >
  > But perhaps AppletInterface sees that we force expanded rep and then ignores that \
request.  
  
  to me a pinned calendar gets correctly closed, not the systray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4842

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol


[Attachment #3 (text/html)]

<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4842" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D4842#90987" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D4842#90987</a>, <a \
href="https://phabricator.kde.org/p/broulik/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Of course I meant the code in panel \
containment, but here it does expanded = false and that&#039;s what I wanted to \
listen to :)</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, \
                0.08);">Plasmoid.onUserConfiguringChanged: {
    ...
        if (plasmoid.userConfiguring) {
            for (var i = 0; i &lt; plasmoid.applets.length; ++i) {
                plasmoid.applets[i].expanded = false;
            }
        ...
}</pre></div>

<p>But perhaps AppletInterface sees that we force expanded rep and then ignores that \
request.</p></div> </blockquote>

<p>to me a pinned calendar gets correctly closed, not the systray</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4842" \
rel="noreferrer">https://phabricator.kde.org/D4842</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>mart, \
plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]