[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Changed Subscribers] D4856: Tighter Folder View item delegates.
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-03-01 12:11:37
Message-ID: 20170301121137.124223.69665.F90941CA () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson added inline comments.
INLINE COMMENTS
> FolderItemDelegate.qml:198
> return (icon.height + (2 * units.smallSpacing) + (label.lineCount
> - * theme.mSize(theme.defaultFont).height) + (2 * \
> units.largeSpacing)); + * theme.mSize(theme.defaultFont).height) \
> + (3 * units.smallSpacing)); }
you have 3*INT being added to the height
then have an icon centre aligned inside it
gridUnit/largeSpacing will always be even. smallSpacing might not be.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4856
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4856" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D4856#inline-19690" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">FolderItemDelegate.qml:198</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">return</span> <span \
class="p">(</span><span style="color: #004012">icon</span><span \
class="p">.</span><span style="color: #004012">height</span> <span style="color: \
#aa2211">+</span> <span class="p">(</span><span style="color: #601200">2</span> <span \
style="color: #aa2211">*</span> <span style="color: #004012">units</span><span \
class="p">.</span><span style="color: #004012">smallSpacing</span><span \
class="p">)</span> <span style="color: #aa2211">+</span> <span \
class="p">(</span><span style="color: #004012">label</span><span \
class="p">.</span><span style="color: #004012">lineCount</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"> <span \
style="color: #aa2211">*</span> <span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">mSize</span><span \
class="p">(</span><span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">defaultFont</span><span \
class="p">).</span><span style="color: #004012">height</span><span class="p">)</span> \
<span style="color: #aa2211">+</span> <span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#601200"><span class="bright">2</span></span> <span style="color: #aa2211">*</span> \
<span style="color: #004012">units</span><span class="p">.<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">large</span>Spacing</span><span class="p">));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span style="color: #aa2211">*</span> <span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">mSize</span><span \
class="p">(</span><span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">defaultFont</span><span \
class="p">).</span><span style="color: #004012">height</span><span class="p">)</span> \
<span style="color: #aa2211">+</span> <span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#601200"><span class="bright">3</span></span> <span style="color: #aa2211">*</span> \
<span style="color: #004012">units</span><span class="p">.<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">small</span>Spacing</span><span class="p">));</span> \
</div><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you \
have 3*INT being added to the height<br /> then have an icon centre aligned inside \
it</p>
<p style="padding: 0; margin: 8px;">gridUnit/largeSpacing will always be even. \
smallSpacing might not be.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4856" \
rel="noreferrer">https://phabricator.kde.org/D4856</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, Plasma<br /><strong>Cc: </strong>davidedmundson, \
broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic