[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 126946: Remove specific X11 code
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2017-03-01 8:30:37
Message-ID: 20170301083037.20993.48484 () mimi ! kde ! org
[Download RAW message or body]
--===============8030064408800089284==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126946/
-----------------------------------------------------------
(Updated March 1, 2017, 10:30 a.m.)
Status
------
This change has been discarded.
Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco Martin.
Repository: kdeplasma-addons
Description
-------
Activity pager settings -> Selecting current desktop -> showDesktop. If desktop is \
showed by clicking on widget, it can be restored by clicking on item in task manager, \
which lead m_desktopDown to store incorrect state.
Diffs
-----
applets/activitypager/plugin/activitypager.h d33e81e
applets/activitypager/plugin/activitypager.cpp b991bac
Diff: https://git.reviewboard.kde.org/r/126946/diff/
Testing
-------
I'm not pretty sure QWindow::fromWinId works on Wayland and must be correcly \
implement
Thanks,
Anthony Fieroni
--===============8030064408800089284==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126946/">https://git.reviewboard.kde.org/r/126946/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson, Martin Gräßlin, and Marco \
Martin.</div> <div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated March 1, 2017, 10:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Activity pager settings -> Selecting current \
desktop -> showDesktop. If desktop is showed by clicking on widget, it can be \
restored by clicking on item in task manager, which lead m_desktopDown to store \
incorrect state.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm not pretty sure QWindow::fromWinId works on \
Wayland and must be correcly implement</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/activitypager/plugin/activitypager.h <span style="color: \
grey">(d33e81e)</span></li>
<li>applets/activitypager/plugin/activitypager.cpp <span style="color: \
grey">(b991bac)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126946/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8030064408800089284==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic