[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 60 lines] D4848: Split frag and vert code of FadingNode into separate files
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-02-28 23:48:16
Message-ID: differential-rev-PHID-DREV-qs2k4pg4vuawpepprrpc-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This matches what Qt does internally, it's easier to read and gives us
  syntax highlighting on the shader files, but more importantly in future
  we will get Qt's automatic loading of core profile shaders.

TEST PLAN
  Opened QML with IconItem, made the icon switch.
  Still looks the same

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4848

AFFECTED FILES
  src/declarativeimports/core/CMakeLists.txt
  src/declarativeimports/core/fadingmaterial.frag
  src/declarativeimports/core/fadingmaterial.vert
  src/declarativeimports/core/fadingnode.cpp
  src/declarativeimports/core/shaders.qrc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added projects: Plasma, Frameworks.<br />Restricted Application added \
subscribers: Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4848" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This \
matches what Qt does internally, it&#039;s easier to read and gives us<br /> syntax \
highlighting on the shader files, but more importantly in future<br /> we will get \
Qt&#039;s automatic loading of core profile shaders.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Opened QML with IconItem, made the icon \
switch.<br /> Still looks the same</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4848" \
rel="noreferrer">https://phabricator.kde.org/D4848</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/core/CMakeLists.txt<br /> \
src/declarativeimports/core/fadingmaterial.frag<br /> \
src/declarativeimports/core/fadingmaterial.vert<br /> \
src/declarativeimports/core/fadingnode.cpp<br /> \
src/declarativeimports/core/shaders.qrc</div></div></div><br /><div><strong>EMAIL \
PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, Frameworks, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]