[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Updated] D4845: Fix context menu button's icon size when on default DPI
From:       Chris Holland <noreply () phabricator ! kde ! org>
Date:       2017-02-28 17:44:01
Message-ID: 20170228174357.92331.46746.66CA0388 () phabricator ! kde ! org
[Download RAW message or body]

Zren edited the summary of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4845

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, subdiff, drosca, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Attachment #3 (text/html)]

<table><tr><td style="">Zren edited the summary of this revision. <a \
href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-ctjrjzqfsu7czp7/" \
rel="noreferrer">(Show Details)</a> </td><a style="text-decoration: none; padding: \
4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D4845" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>CHANGES TO REVISION \
SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;">ToolButton \
pads the contexts of the label+icon based on the desktop theme&#039;s svg margins. \
Causing the icon to only be 12px, which is scaled down and looks like a solid square \
with the breeze icon, as seen in D4751 comments. We want this button to be reasonably \
small, but should have the minimum of a 16px icon. The button itself is <span \
style="padding: 0 2px; color: #333333; background: #f8cbcb;">18</span><span \
style="padding: 0 2px; color: #333333; background: #a6f3a6;">24</span>px atm<span \
style="padding: 0 2px; color: #333333; background: #a6f3a6;"> (based off the \
`slider.height`)</span>. Since the icon doesn&#039;t go right to the edge, we can \
just overlay the icon on top of the button and apply all the ToolButtonStyle \
effects.<br /> <br />
<span style="padding: 0 2px; color: #333333; background: \
#a6f3a6;">{F2669014}</span></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D4845" \
rel="noreferrer">https://phabricator.kde.org/D4845</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>Zren, subdiff, drosca, broulik<br /><strong>Cc: \
</strong>plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]